Page MenuHomePhabricator
Differential D8601

[CommCoreModule] Move `runSyncOrThrowJSError` to a separate file
ClosedPublic
Actions

Authored by kamil on Jul 24 2023, 3:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 2:58 PM
Unknown Object (File)
Sat, Nov 23, 2:36 PM
Unknown Object (File)
Sat, Nov 23, 2:36 PM
Unknown Object (File)
Thu, Nov 21, 12:01 AM
Unknown Object (File)
Thu, Nov 7, 3:24 AM
Unknown Object (File)
Tue, Nov 5, 7:18 AM
Unknown Object (File)
Tue, Nov 5, 7:18 AM
Unknown Object (File)
Tue, Nov 5, 7:18 AM
View All 95 Files
Subscribers
ashoat

Details

Reviewers
michal
• jon
atul
tomek
Commits
rCOMMc1edc0cb9b40: [CommCoreModule] Move `runSyncOrThrowJSError` to a separate file
Summary

Currently working on reducing code duplication and cleanup in this file. So I will need to use this function in different places as well as here (for functions like getAllMessagesSync).

It's easy util, so I prefer to keep this in .h file.

Test Plan

Build iOS and Android

Diff Detail

Repository
rCOMM Comm
Branch
core-module-refactor
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
1 line
2 lines
42 lines
40 lines
ios/
Comm.xcodeproj/
2 lines

Diff 28955

View Options

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/NativeModuleUtils.h

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...