Page MenuHomePhabricator
Differential D8601

[CommCoreModule] Move `runSyncOrThrowJSError` to a separate file
ClosedPublic
Actions

Authored by kamil on Jul 24 2023, 3:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 15 2025, 6:31 PM
Unknown Object (File)
Mar 13 2025, 10:31 AM
Unknown Object (File)
Mar 13 2025, 10:31 AM
Unknown Object (File)
Mar 13 2025, 10:31 AM
Unknown Object (File)
Mar 13 2025, 10:27 AM
Unknown Object (File)
Mar 13 2025, 8:21 AM
Unknown Object (File)
Feb 18 2025, 8:05 AM
Unknown Object (File)
Feb 15 2025, 4:05 PM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
• jon
atul
tomek
Commits
rCOMMc1edc0cb9b40: [CommCoreModule] Move `runSyncOrThrowJSError` to a separate file
Summary

Currently working on reducing code duplication and cleanup in this file. So I will need to use this function in different places as well as here (for functions like getAllMessagesSync).

It's easy util, so I prefer to keep this in .h file.

Test Plan

Build iOS and Android

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
1 line
2 lines
42 lines
40 lines
ios/
Comm.xcodeproj/
2 lines

Diff 29281

View Options

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override; setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override;
jsi::Value getCurrentUserID(jsi::Runtime &rt) override; jsi::Value getCurrentUserID(jsi::Runtime &rt) override;
jsi::Value
setDeviceID(jsi::Runtime &rt, const jsi::String &deviceType) override;
jsi::Value getDeviceID(jsi::Runtime &rt) override;
jsi::Value clearSensitiveData(jsi::Runtime &rt) override; jsi::Value clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override; setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override;
jsi::Value getCurrentUserID(jsi::Runtime &rt) override; jsi::Value getCurrentUserID(jsi::Runtime &rt) override;
jsi::Value
setDeviceID(jsi::Runtime &rt, const jsi::String &deviceType) override;
jsi::Value getDeviceID(jsi::Runtime &rt) override;
jsi::Value clearSensitiveData(jsi::Runtime &rt) override; jsi::Value clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override; setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override;
jsi::Value getCurrentUserID(jsi::Runtime &rt) override; jsi::Value getCurrentUserID(jsi::Runtime &rt) override;
jsi::Value
setDeviceID(jsi::Runtime &rt, const jsi::String &deviceType) override;
jsi::Value getDeviceID(jsi::Runtime &rt) override;
jsi::Value clearSensitiveData(jsi::Runtime &rt) override; jsi::Value clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm
View Options

native/cpp/CommonCpp/NativeModules/NativeModuleUtils.h

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override; setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override;
jsi::Value getCurrentUserID(jsi::Runtime &rt) override; jsi::Value getCurrentUserID(jsi::Runtime &rt) override;
jsi::Value
setDeviceID(jsi::Runtime &rt, const jsi::String &deviceType) override;
jsi::Value getDeviceID(jsi::Runtime &rt) override;
jsi::Value clearSensitiveData(jsi::Runtime &rt) override; jsi::Value clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override; setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override;
jsi::Value getCurrentUserID(jsi::Runtime &rt) override; jsi::Value getCurrentUserID(jsi::Runtime &rt) override;
jsi::Value
setDeviceID(jsi::Runtime &rt, const jsi::String &deviceType) override;
jsi::Value getDeviceID(jsi::Runtime &rt) override;
jsi::Value clearSensitiveData(jsi::Runtime &rt) override; jsi::Value clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm