Page MenuHomePhabricator
Differential D8885

[client-backup] implement Rust function for computing `BackupKey`
ClosedPublic
Actions

Authored by kamil on Aug 21 2023, 4:47 AM.
Tags
None
Referenced Files
F2071900: D8885.diff
Sat, Jun 22, 2:34 AM
Unknown Object (File)
Sun, May 26, 9:26 AM
Unknown Object (File)
Sun, May 26, 9:26 AM
Unknown Object (File)
Sun, May 26, 9:26 AM
Unknown Object (File)
Sun, May 26, 9:26 AM
Unknown Object (File)
Sun, May 26, 9:23 AM
Unknown Object (File)
Sat, May 25, 12:44 AM
Unknown Object (File)
Thu, May 23, 8:37 PM
View All 92 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
marcin
Commits
rCOMM0064989dafdd: [client-backup] implement Rust function for computing `BackupKey`
Summary

ENG-4512.

Docs.

Function to compute (KDF) for hashing a password with BackupID.

Depends on D8884

Test Plan

cargo test in native_rust_library

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Aug 21 2023, 4:47 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 21 2023, 4:47 AM
kamil added a child revision: D8886: [client-backup] implement C++ function for computing `BackupKey`.Aug 21 2023, 4:57 AM
Harbormaster completed remote builds in B21941: Diff 30133.Aug 21 2023, 5:04 AM
kamil published this revision for review.Aug 21 2023, 6:35 AM
marcin accepted this revision.Aug 22 2023, 1:43 AM

Accepting but I am not Rust expert so try to get @michal acceptance before landing.

This revision is now accepted and ready to land.Aug 22 2023, 1:43 AM
michal accepted this revision.Aug 22 2023, 2:37 AM

LGTM on the rust side

kamil mentioned this in D8998: [client-backup] add JS function to compute BackupKey based on user credentials.Aug 29 2023, 2:34 AM
kamil updated this revision to Diff 30585.Aug 30 2023, 10:35 AM

lint

Harbormaster completed remote builds in B22276: Diff 30585.Aug 30 2023, 10:52 AM
Closed by commit rCOMM0064989dafdd: [client-backup] implement Rust function for computing `BackupKey` (authored by kamil). · Explain WhyAug 30 2023, 10:54 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM0064989dafdd: [client-backup] implement Rust function for computing `BackupKey`.
kamil mentioned this in rCOMM9fe2e32bfdc4: [client-backup] add JS function to compute BackupKey based on user credentials.Aug 31 2023, 1:53 PM

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
65 lines
6 lines

Diff 30587

View Options

native/native_rust_library/src/argon2_tools.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...