Page MenuHomePhabricator
Differential D8996

[client-backup] implement API call to get UserData
ClosedPublic
Actions

Authored by kamil on Aug 29 2023, 2:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 4:53 PM
Unknown Object (File)
Wed, Mar 26, 1:40 PM
Unknown Object (File)
Wed, Mar 26, 1:40 PM
Unknown Object (File)
Wed, Mar 26, 1:40 PM
Unknown Object (File)
Wed, Mar 26, 1:40 PM
Unknown Object (File)
Wed, Mar 26, 6:57 AM
Unknown Object (File)
Sun, Mar 23, 9:34 AM
Unknown Object (File)
Sun, Mar 16, 11:46 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
marcin
bartek
Commits
rCOMMc29a59e1da0a: [client-backup] implement API call to get UserData
Summary

Call to get UserData associated with given BackupID.

Depends on D8995

Test Plan

Call this with mock data and verify result is correct.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Aug 29 2023, 2:21 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 29 2023, 2:21 AM
kamil added a child revision: D8997: [client-backup] extract code to handle HTTP error.Aug 29 2023, 2:31 AM
Harbormaster completed remote builds in B22199: Diff 30475.Aug 29 2023, 2:38 AM
kamil published this revision for review.Aug 29 2023, 3:19 AM
kamil added a reviewer: bartek.
michal accepted this revision.Aug 29 2023, 7:52 AM

LGTM, it's really similar to the previous diff, so I'm assuming any react native stuff will get solved there

This revision is now accepted and ready to land.Aug 29 2023, 7:52 AM
bartek accepted this revision.Aug 30 2023, 11:53 AM
kamil updated this revision to Diff 30671.Aug 31 2023, 1:21 PM

rebase

Harbormaster completed remote builds in B22327: Diff 30671.Aug 31 2023, 1:40 PM
Closed by commit rCOMMc29a59e1da0a: [client-backup] implement API call to get UserData (authored by kamil). · Explain WhyAug 31 2023, 1:53 PM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMc29a59e1da0a: [client-backup] implement API call to get UserData.

Revision Contents
Changeset List

PathSize
native/
backup/
28 lines

Diff 30675

View Options

native/backup/api.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines