Paths

Table of Contentst

Differential D8995

[client-backup] implement API call to get UserKeys
ClosedPublic
Actions

Authored by kamil on Aug 29 2023, 2:19 AM.

Tags

None

Referenced Files

	F3337413: D8995.diff
	Thu, Nov 21, 4:35 PM

	Unknown Object (File)
	Tue, Oct 29, 8:54 AM

	Unknown Object (File)
	Sun, Oct 27, 4:09 PM

	Unknown Object (File)
	Sep 28 2024, 6:22 AM

	Unknown Object (File)
	Sep 27 2024, 11:27 PM

	Unknown Object (File)
	Sep 27 2024, 11:27 PM

	Unknown Object (File)
	Sep 27 2024, 11:27 PM

	Unknown Object (File)
	Sep 27 2024, 11:26 PM

Subscribers

Details

Reviewers

michal
marcin
bartek

Commits

rCOMMa735a0db5084: [client-backup] implement API call to get UserKeys

Summary

Call to get UserKeys associated with given BackupID

Depends on D8994

Test Plan

Call this with mock data and verify data is correct.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 29 2023, 2:19 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 29 2023, 2:19 AM

kamil added a child revision: D8996: [client-backup] implement API call to get UserData.Aug 29 2023, 2:21 AM

Harbormaster completed remote builds in B22198: Diff 30474.Aug 29 2023, 2:35 AM

kamil published this revision for review.Aug 29 2023, 3:18 AM

kamil added inline comments.

native/backup/conversion-utils.js
9 ↗	(On Diff #30474)	opposite operations to those in D8993

marcin added inline comments.Aug 29 2023, 6:27 AM

native/backup/conversion-utils.js
9 ↗	(On Diff #30474)	Could this work: https://bun.sh/guides/binary/blob-to-typedarray?

kamil added inline comments.Aug 29 2023, 6:32 AM

native/backup/conversion-utils.js
9 ↗	(On Diff #30474)	Could this work: https://bun.sh/guides/binary/blob-to-typedarray? I don't think so - the code you provided is doing the same thing as line 7 (it skips decoding base64).

bartek added inline comments.Aug 29 2023, 6:41 AM

native/backup/conversion-utils.js
9 ↗	(On Diff #30474)	Could this work: https://bun.sh/guides/binary/blob-to-typedarray? Maybe in Bun runtime it works well, but not in React Native: https://linear.app/comm/issue/ENG-3718/improve-fetch-to-arraybuffer-performance-even-more This is the exact reason I introduced all these utilities

LGTM on the backup api, not accepting because it seems like there is some discussion on react-native side, that I'm not very familiar

bartek accepted this revision.Aug 30 2023, 11:52 AM

This revision is now accepted and ready to land.Aug 30 2023, 11:52 AM

address https://phab.comm.dev/D9002#inline-57508

Harbormaster completed remote builds in B22326: Diff 30670.Aug 31 2023, 1:35 PM

Closed by commit rCOMMa735a0db5084: [client-backup] implement API call to get UserKeys (authored by kamil). · Explain WhyAug 31 2023, 1:53 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa735a0db5084: [client-backup] implement API call to get UserKeys.

Revision Contents
Changeset List

Path

Size

native/

backup/

29 lines

conversion-utils.js

13 lines

Diff 30674

native/backup/api.js

Loading...

native/backup/conversion-utils.js

Loading...