Paths

Table of Contentst

Differential D9003

[client-backup] implement backup handler
ClosedPublic
Actions

Authored by kamil on Aug 29 2023, 9:52 AM.

Tags

None

Referenced Files

	F729717: image.png
	Aug 29 2023, 10:30 AM

	F729716: image.png
	Aug 29 2023, 10:30 AM

Subscribers

Details

Reviewers

michal
marcin
bartek
inka

Commits

rCOMM4ab2a5637e7a: [client-backup] implement backup handler

Summary

For now in UserData we store UserStore. Each time it changes we upload a new backup.

Depends on D9002

Test Plan

Test both successful and failed uploads.

image.png (789×391 px, 74 KB)

image.png (803×392 px, 87 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 29 2023, 9:52 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 29 2023, 9:52 AM

kamil added a child revision: D9004: [client-backup] add restore test.Aug 29 2023, 9:54 AM

Harbormaster failed remote builds in B22206: Diff 30482!Aug 29 2023, 10:03 AM

kamil edited the summary of this revision. (Show Details)Aug 29 2023, 10:30 AM

kamil edited the test plan for this revision. (Show Details)

CI

Harbormaster failed remote builds in B22209: Diff 30485!Aug 29 2023, 10:46 AM

CI again

kamil published this revision for review.Aug 29 2023, 11:05 AM

Harbormaster completed remote builds in B22210: Diff 30486.Aug 29 2023, 11:06 AM

kamil added a child revision: D9010: [client-backup] add local settings to store.Aug 29 2023, 2:35 PM

kamil removed a child revision: D9004: [client-backup] add restore test.Aug 29 2023, 2:39 PM

kamil added a child revision: D9004: [client-backup] add restore test.Aug 29 2023, 2:41 PM

kamil removed a child revision: D9004: [client-backup] add restore test.Aug 29 2023, 2:51 PM

kamil added a child revision: D9004: [client-backup] add restore test.Aug 29 2023, 2:54 PM

kamil removed a child revision: D9004: [client-backup] add restore test.Aug 29 2023, 2:55 PM

kamil added a reviewer: inka.Aug 29 2023, 3:38 PM

michal added inline comments.Aug 29 2023, 5:34 PM

native/backup/backup-handler.js
38 ↗	(On Diff #30486)	What do you think?
54 ↗	(On Diff #30486)	Even if it's opt-in we probably don't need to display the alert on success

bartek added inline comments.Aug 29 2023, 8:13 PM

native/backup/backup-handler.js
54 ↗	(On Diff #30486)	We have so much alert spam already 😅

remove success info
rename some vars

kamil added inline comments.Sep 4 2023, 10:10 AM

native/backup/backup-handler.js
38 ↗	(On Diff #30486)	I'm not convinced, `sha256Hash` is more current hash, value from `AsyncStorage` is recent as it was computed previously 😅
54 ↗	(On Diff #30486)	okay, I wanted to check how frequent data is backed up - but we can always check this in backup service logs

kamil added a child revision: D9004: [client-backup] add restore test.Sep 4 2023, 10:14 AM

kamil removed a child revision: D9004: [client-backup] add restore test.Sep 4 2023, 10:14 AM

Harbormaster completed remote builds in B22367: Diff 30734.Sep 4 2023, 10:25 AM

michal accepted this revision.Sep 4 2023, 3:31 PM

michal added inline comments.

native/backup/backup-handler.js
38 ↗	(On Diff #30486)	What about `mostRecentlyUploadedBackupHash`? :P

This revision is now accepted and ready to land.Sep 4 2023, 3:31 PM

Closed by commit rCOMM4ab2a5637e7a: [client-backup] implement backup handler. · Explain WhySep 5 2023, 12:13 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM4ab2a5637e7a: [client-backup] implement backup handler.

kamil mentioned this in D9080: [client-backup] rename `recentBackupHash` -> `mostRecentlyUploadedBackupHash`.Sep 5 2023, 12:14 PM

kamil mentioned this in rCOMMfc35759754a3: [client-backup] rename `recentBackupHash` -> `mostRecentlyUploadedBackupHash`.Sep 5 2023, 12:47 PM

Revision Contents
Changeset List

Path

Size

native/

backup/

backup-handler.js

62 lines

2 lines

2 lines

Diff 30752

native/backup/backup-handler.js

Loading...

native/backup/constants.js

Loading...

native/root.react.js

Loading...