Paths

Table of Contentst

Differential D8994

[client-backup] implement API call to get BackupID
ClosedPublic
Actions

Authored by kamil on Aug 29 2023, 9:15 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

michal
marcin
bartek

Commits

rCOMMcd09838bc411: [client-backup] implement API call to get BackupID

Summary

Call without auth to get latest BackupID.

Depends on D8993

Test Plan

Call this with mock data and verify it's lastly uploaded backupID

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 29 2023, 9:15 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 29 2023, 9:15 AM

fix typo

kamil added a child revision: D8995: [client-backup] implement API call to get UserKeys.Aug 29 2023, 9:19 AM

Harbormaster failed remote builds in B22196: Diff 30472!Aug 29 2023, 9:25 AM

Harbormaster completed remote builds in B22197: Diff 30473.Aug 29 2023, 9:33 AM

kamil added a parent revision: D8888: [client-backup] implement C++ functions for encoding/decoding string in `utf-8`.Aug 29 2023, 10:16 AM

kamil added inline comments.

native/backup/api.js
74 ↗	(On Diff #30473)	it was generated and sent as string do we can be confident is decodable

kamil published this revision for review.Aug 29 2023, 10:17 AM

marcin added inline comments.Aug 29 2023, 1:52 PM

native/backup/api.js
58 ↗	(On Diff #30473)	Why isn't this one authenticated?

michal added inline comments.Aug 29 2023, 2:31 PM

native/backup/api.js
58 ↗	(On Diff #30473)	Both "backups/latest/" endpoints (one for fetching backupID and one for fetching user keys) will be used in the primary device restoration flow. When the primary device restores from backup we only know username and password (or eth equivalent) that user put in. But to authenticate with the identity service we need to first download userKeys and decrypt them. So we can't require authorisation for backupID and userKeys. After decrypting userKeys the device can authenticate with the identity service. Then it can download the userData (which requires authentication).
72–75 ↗	(On Diff #30473)	I might be missing something but isn't there just like `response.json()` method?

use json()

native/backup/api.js
72–75 ↗	(On Diff #30473)	right! updating

michal accepted this revision.Aug 29 2023, 4:08 PM

This revision is now accepted and ready to land.Aug 29 2023, 4:08 PM

Harbormaster completed remote builds in B22230: Diff 30514.Aug 29 2023, 4:23 PM

bartek accepted this revision.Aug 30 2023, 6:54 PM

Closed by commit rCOMMcd09838bc411: [client-backup] implement API call to get BackupID. · Explain WhyAug 31 2023, 8:53 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMcd09838bc411: [client-backup] implement API call to get BackupID.

Revision Contents
Changeset List

Path

Size

native/

backup/

20 lines

Diff 30673

native/backup/api.js

Loading...