Page MenuHomePhabricator
Differential D9001

[client-backup] implement initial backup protocol
ClosedPublic
Actions

Authored by kamil on Aug 29 2023, 2:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 16, 11:26 PM
Unknown Object (File)
Sun, Mar 16, 11:25 PM
Unknown Object (File)
Fri, Mar 7, 9:48 AM
Unknown Object (File)
Sat, Feb 22, 5:56 PM
Unknown Object (File)
Jan 15 2025, 3:09 PM
Unknown Object (File)
Jan 11 2025, 6:48 PM
Unknown Object (File)
Jan 6 2025, 2:13 AM
Unknown Object (File)
Jan 6 2025, 2:13 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
marcin
bartek
Commits
rCOMM74ecd7947bd7: [client-backup] implement initial backup protocol
Summary

Function performing full backup.

Depends on D9000

Test Plan

Call uploadBackup function and make sure content was uploaded.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Aug 29 2023, 2:44 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 29 2023, 2:44 AM
kamil added a child revision: D9002: [client-backup] implement initial restore backup protocol.Aug 29 2023, 2:47 AM
Harbormaster failed remote builds in B22204: Diff 30480!Aug 29 2023, 2:53 AM
kamil updated this revision to Diff 30484.Aug 29 2023, 3:26 AM

fix name conflict

kamil published this revision for review.Aug 29 2023, 3:35 AM
Harbormaster completed remote builds in B22208: Diff 30484.Aug 29 2023, 3:43 AM
marcin added inline comments.Aug 29 2023, 6:50 AM
native/backup/use-client-backup.js
44 ↗(On Diff #30484)

Nit: you can let this promise and the two above run simultaneously.

michal added inline comments.Aug 29 2023, 8:02 AM
native/backup/use-client-backup.js
56 ↗(On Diff #30484)

Is this only temporary? Should we also add accessToken to the if at the beginning?

kamil added inline comments.Aug 29 2023, 9:12 AM
native/backup/use-client-backup.js
44 ↗(On Diff #30484)

I think only one above (getUserPublicKey) but you're right, I will update before landing

56 ↗(On Diff #30484)

it's temporary, I will update after CommAccessToken is available on native (and until it's ignored in services codebase)

kamil mentioned this in D9002: [client-backup] implement initial restore backup protocol.Aug 29 2023, 9:17 AM
michal accepted this revision.Aug 30 2023, 7:04 AM
This revision is now accepted and ready to land.Aug 30 2023, 7:04 AM
kamil added a child revision: D9074: [client-backup] extract logic for getting primary identity public key.Sep 4 2023, 1:53 AM
kamil removed a child revision: D9002: [client-backup] implement initial restore backup protocol.Sep 4 2023, 3:00 AM
kamil updated this revision to Diff 30732.Sep 4 2023, 3:02 AM

rebase

native/backup/use-client-backup.js
44 ↗(On Diff #30484)

addressed in D9074

kamil added a child revision: D9002: [client-backup] implement initial restore backup protocol.Sep 4 2023, 3:05 AM
kamil removed a child revision: D9002: [client-backup] implement initial restore backup protocol.Sep 4 2023, 3:06 AM
Harbormaster completed remote builds in B22365: Diff 30732.Sep 4 2023, 3:20 AM
kamil added a child revision: D9002: [client-backup] implement initial restore backup protocol.Sep 5 2023, 2:12 AM
kamil removed a child revision: D9002: [client-backup] implement initial restore backup protocol.Sep 5 2023, 5:04 AM
Closed by commit rCOMM74ecd7947bd7: [client-backup] implement initial backup protocol (authored by kamil). · Explain WhySep 5 2023, 5:13 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM74ecd7947bd7: [client-backup] implement initial backup protocol.

Revision Contents
Changeset List

PathSize
native/
backup/
3 lines
69 lines

Diff 30749

View Options

native/backup/constants.js

  • This file was added.
#pragma once
#include <grpcpp/grpcpp.h>
#include <iostream>
#include <memory>
#include <string>
namespace comm {
namespace network {
namespace reactor {
struct ServerBidiReactorStatus {
grpc::Status status = grpc::Status::OK;
bool sendLastResponse = false;
ServerBidiReactorStatus(
grpc::Status status = grpc::Status::OK,
bool sendLastResponse = false)
: status(status), sendLastResponse(sendLastResponse) {
}
};
template <class Request, class Response>
class ServerBidiReactorBase
: public grpc::ServerBidiReactor<Request, Response> {
Request request;
Response response;
protected:
ServerBidiReactorStatus status;
bool readingAborted = false;
public:
ServerBidiReactorBase();
void OnDone() override;
void OnReadDone(bool ok) override;
void OnWriteDone(bool ok) override;
void terminate(ServerBidiReactorStatus status);
virtual std::unique_ptr<ServerBidiReactorStatus>
handleRequest(Request request, Response *response) = 0;
virtual void initialize(){};
virtual void doneCallback(){};
};
template <class Request, class Response>
ServerBidiReactorBase<Request, Response>::ServerBidiReactorBase() {
this->initialize();
this->StartRead(&this->request);
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnDone() {
this->doneCallback();
delete this;
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::terminate(
ServerBidiReactorStatus status) {
this->status = status;
if (this->status.sendLastResponse) {
this->StartWriteAndFinish(
&this->response, grpc::WriteOptions(), this->status.status);
} else {
this->Finish(this->status.status);
}
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnReadDone(bool ok) {
if (!ok) {
this->readingAborted = true;
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::ABORTED, "no more reads")));
return;
}
try {
this->response = Response();
std::unique_ptr<ServerBidiReactorStatus> status =
this->handleRequest(this->request, &this->response);
if (status != nullptr) {
this->terminate(*status);
return;
}
this->StartWrite(&this->response);
} catch (std::runtime_error &e) {
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::INTERNAL, e.what())));
}
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnWriteDone(bool ok) {
if (!ok) {
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::ABORTED, "write failed")));
return;
}
this->StartRead(&this->request);
}
} // namespace reactor
} // namespace network
} // namespace comm
View Options

native/backup/use-client-backup.js

  • This file was added.
#pragma once
#include <grpcpp/grpcpp.h>
#include <iostream>
#include <memory>
#include <string>
namespace comm {
namespace network {
namespace reactor {
struct ServerBidiReactorStatus {
grpc::Status status = grpc::Status::OK;
bool sendLastResponse = false;
ServerBidiReactorStatus(
grpc::Status status = grpc::Status::OK,
bool sendLastResponse = false)
: status(status), sendLastResponse(sendLastResponse) {
}
};
template <class Request, class Response>
class ServerBidiReactorBase
: public grpc::ServerBidiReactor<Request, Response> {
Request request;
Response response;
protected:
ServerBidiReactorStatus status;
bool readingAborted = false;
public:
ServerBidiReactorBase();
void OnDone() override;
void OnReadDone(bool ok) override;
void OnWriteDone(bool ok) override;
void terminate(ServerBidiReactorStatus status);
virtual std::unique_ptr<ServerBidiReactorStatus>
handleRequest(Request request, Response *response) = 0;
virtual void initialize(){};
virtual void doneCallback(){};
};
template <class Request, class Response>
ServerBidiReactorBase<Request, Response>::ServerBidiReactorBase() {
this->initialize();
this->StartRead(&this->request);
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnDone() {
this->doneCallback();
delete this;
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::terminate(
ServerBidiReactorStatus status) {
this->status = status;
if (this->status.sendLastResponse) {
this->StartWriteAndFinish(
&this->response, grpc::WriteOptions(), this->status.status);
} else {
this->Finish(this->status.status);
}
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnReadDone(bool ok) {
if (!ok) {
this->readingAborted = true;
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::ABORTED, "no more reads")));
return;
}
try {
this->response = Response();
std::unique_ptr<ServerBidiReactorStatus> status =
this->handleRequest(this->request, &this->response);
if (status != nullptr) {
this->terminate(*status);
return;
}
this->StartWrite(&this->response);
} catch (std::runtime_error &e) {
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::INTERNAL, e.what())));
}
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnWriteDone(bool ok) {
if (!ok) {
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::ABORTED, "write failed")));
return;
}
this->StartRead(&this->request);
}
} // namespace reactor
} // namespace network
} // namespace comm