Paths

Table of Contentst

Differential D9001

[client-backup] implement initial backup protocol
ClosedPublic
Actions

Authored by kamil on Aug 29 2023, 2:44 AM.

Tags

None

Referenced Files

	F2129802: D9001.diff
	Thu, Jun 27, 2:13 PM

	F2123793: D9001.id30749.diff
	Wed, Jun 26, 7:12 PM

	Unknown Object (File)
	Wed, Jun 26, 1:46 PM

	Unknown Object (File)
	Tue, Jun 25, 9:50 PM

	Unknown Object (File)
	Tue, Jun 25, 7:22 PM

	Unknown Object (File)
	Tue, Jun 25, 4:40 AM

	Unknown Object (File)
	Tue, Jun 25, 4:40 AM

	Unknown Object (File)
	Tue, Jun 25, 4:40 AM

View All 83 Files

Subscribers

Details

Reviewers

michal
marcin
bartek

Commits

rCOMM74ecd7947bd7: [client-backup] implement initial backup protocol

Summary

Function performing full backup.

Depends on D9000

Test Plan

Call uploadBackup function and make sure content was uploaded.

Diff Detail

Repository

Branch

client-backup

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 29 2023, 2:44 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 29 2023, 2:44 AM

kamil added a child revision: D9002: [client-backup] implement initial restore backup protocol.Aug 29 2023, 2:47 AM

Harbormaster failed remote builds in B22204: Diff 30480!Aug 29 2023, 2:53 AM

fix name conflict

kamil published this revision for review.Aug 29 2023, 3:35 AM

Harbormaster completed remote builds in B22208: Diff 30484.Aug 29 2023, 3:43 AM

marcin added inline comments.Aug 29 2023, 6:50 AM

native/backup/use-client-backup.js
44 ↗	(On Diff #30484)	Nit: you can let this promise and the two above run simultaneously.

michal added inline comments.Aug 29 2023, 8:02 AM

native/backup/use-client-backup.js
56 ↗	(On Diff #30484)	Is this only temporary? Should we also add accessToken to the if at the beginning?

kamil added inline comments.Aug 29 2023, 9:12 AM

native/backup/use-client-backup.js
44 ↗	(On Diff #30484)	I think only one above (`getUserPublicKey`) but you're right, I will update before landing
56 ↗	(On Diff #30484)	it's temporary, I will update after `CommAccessToken` is available on native (and until it's ignored in services codebase)

kamil mentioned this in D9002: [client-backup] implement initial restore backup protocol.Aug 29 2023, 9:17 AM

michal accepted this revision.Aug 30 2023, 7:04 AM

This revision is now accepted and ready to land.Aug 30 2023, 7:04 AM

kamil added a child revision: D9074: [client-backup] extract logic for getting primary identity public key.Sep 4 2023, 1:53 AM

kamil removed a child revision: D9002: [client-backup] implement initial restore backup protocol.Sep 4 2023, 3:00 AM

rebase

native/backup/use-client-backup.js
44 ↗	(On Diff #30484)	addressed in D9074

kamil added a child revision: D9002: [client-backup] implement initial restore backup protocol.Sep 4 2023, 3:05 AM

kamil removed a child revision: D9002: [client-backup] implement initial restore backup protocol.Sep 4 2023, 3:06 AM

Harbormaster completed remote builds in B22365: Diff 30732.Sep 4 2023, 3:20 AM

kamil added a child revision: D9002: [client-backup] implement initial restore backup protocol.Sep 5 2023, 2:12 AM

kamil removed a child revision: D9002: [client-backup] implement initial restore backup protocol.Sep 5 2023, 5:04 AM

Closed by commit rCOMM74ecd7947bd7: [client-backup] implement initial backup protocol (authored by kamil). · Explain WhySep 5 2023, 5:13 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM74ecd7947bd7: [client-backup] implement initial backup protocol.

Revision Contents
Changeset List

Path

Size

native/

backup/

3 lines

use-client-backup.js

68 lines

Diff 30480

native/backup/constants.js

Loading...

native/backup/use-client-backup.js

Loading...