Assuming that it is correct that getBackupID does not take BackupAuth then we should let getBackupID and CommCoreModule promises run simultaneously.

getUserData and getUserKeysAuth look like independent network requests so for the sake of performance we should let those promises run simultaneously.

Is this only temporary? Should we also add accessToken to the if at the beginning?

That's correct although we should probably add a code comment with explanation that this is only for the initial backup version.

(not sure in which diff this function was defined, but my suggestions about endpoint naming also apply here)

Link to related discussion to give more context: https://phab.comm.dev/D8965#inline-57358

yes, responded in https://phab.comm.dev/D9001#inline-57525

That's correct although we should probably add a code comment with explanation that this is only for the initial backup version.

good call

Assuming that it is correct that getBackupID does not take BackupAuth then we should let getBackupID and CommCoreModule promises run simultaneously.

I did it on purpose to then return very detailed result of which promises failed and which did not.

I did it on purpose to then return very detailed result of which promises failed and which did not.

I think you could still run them simultaneously if you wrap the whole try{}catch{} in async functions and run them with Promise.all

+1

This way should be possible - but it slightly decreases readability:

const userKeysResponsePromise = (async () => {
      try {
        const userKeysResponse = await getUserKeysAuth(backupID, backupAuth);
        result.getUserKeys = true;
        return userKeysResponse;
      } catch (e) {
        result.getUserKeys = false;
        result.error = e;
      }
})();

const userDataResponsePromise = // ...

const [userKeysResponse, userDataResponse] = await Promise.all([
  userKeysResponsePromise, userDataResponsePromise
]);

I think we should follow @bartek suggestion. This is both better for performance and it does not violate our code conventions that state we should never let two independent promises run sequentially.