[keyserver] Determine which infos have invalid hashes based on specs
ClosedPublic
Actions

Authored by tomek on Aug 28 2023, 6:28 AM.

Details

Reviewers

kamil
bartek
inka

Commits

rCOMM9f679f8667b0: [keyserver] Determine which infos have invalid hashes based on specs

Summary

Check if a key is top level - it means that there are infos in the collection which aren't synchronized. Iterate over them and compute hashes for each item.
When a spec doesn't specify innerHashKey, return the values immediately - currently we do that only for currentUserInfo because there's exactly one current user.

https://linear.app/comm/issue/ENG-4631/migrate-checkstate-from-session-utils-to-a-spec

Depends on D8977

Test Plan

Modify keyserver db and check if the store get fixed.

Diff Detail

Repository

rCOMM Comm

Branch

state-sync

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Aug 28 2023, 6:28 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2023, 6:29 AM

Harbormaster completed remote builds in B22171: Diff 30437.Aug 28 2023, 6:46 AM

tomek requested review of this revision.Aug 28 2023, 6:46 AM

So it means that innerHashKey is defined only for collections, and should be null / undefined for top-level, non-iterable infos

This revision is now accepted and ready to land.Aug 29 2023, 2:21 AM

tomek added a child revision: D9008: [keyserver] Determine which infos to send based on specs.Aug 29 2023, 6:16 AM

In D8979#265014, @bartek wrote:

So it means that innerHashKey is defined only for collections, and should be null / undefined for top-level, non-iterable infos

Yes, exactly.

Closed by commit rCOMM9f679f8667b0: [keyserver] Determine which infos have invalid hashes based on specs (authored by tomek). · Explain WhyAug 30 2023, 9:16 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM9f679f8667b0: [keyserver] Determine which infos have invalid hashes based on specs.