Page MenuHomePhabricator
Differential D9030

[lib] Convert infos to server as a part of a spec
ClosedPublic
Actions

Authored by tomek on Aug 30 2023, 9:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 10:55 AM
Unknown Object (File)
Fri, Nov 29, 4:24 PM
Unknown Object (File)
Nov 21 2024, 10:07 AM
Unknown Object (File)
Nov 10 2024, 3:59 PM
Unknown Object (File)
Nov 10 2024, 3:59 PM
Unknown Object (File)
Nov 10 2024, 3:59 PM
Unknown Object (File)
Nov 10 2024, 3:58 PM
Unknown Object (File)
Nov 5 2024, 2:12 AM
View All Files
Subscribers
ashoat

Details

Reviewers
kamil
bartek
inka
Commits
rCOMM32c3af6167c3: [lib] Convert infos to server as a part of a spec
Summary

Move the logic to a spec and call it in a selector.

https://linear.app/comm/issue/ENG-4813/migrate-getclientresponsesselector-to-a-spec

Depends on D9025

Test Plan

Modify server state and check if state check fixes client state.

Diff Detail

Repository
rCOMM Comm
Branch
state-sync
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Aug 30 2023, 9:05 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 30 2023, 9:05 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 30 2023, 9:07 AM
Harbormaster failed remote builds in B22274: Diff 30571!
Harbormaster completed remote builds in B22274: Diff 30571.Aug 30 2023, 9:25 AM
tomek requested review of this revision.Aug 30 2023, 9:25 AM
tomek added a child revision: D9031: [lib] Use specs to determine hash value for top-level infos.Aug 30 2023, 9:41 AM
bartek accepted this revision.Aug 31 2023, 12:39 AM

Looks good to me

This revision is now accepted and ready to land.Aug 31 2023, 12:39 AM
kamil added a comment.Sep 4 2023, 5:01 AM

LGTM
One nit: a lot of imports can be merged here 😅

kamil accepted this revision.Sep 4 2023, 5:01 AM
tomek updated this revision to Diff 30760.Sep 5 2023, 5:32 AM

Merge imports

Harbormaster completed remote builds in B22386: Diff 30760.Sep 5 2023, 5:49 AM
Closed by commit rCOMM32c3af6167c3: [lib] Convert infos to server as a part of a spec (authored by tomek). · Explain WhySep 5 2023, 7:03 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM32c3af6167c3: [lib] Convert infos to server as a part of a spec.

Revision Contents
Changeset List

PathSize
keyserver/
src/
shared/
state-sync/
2 lines
lib/
selectors/
68 lines
shared/
state-sync/
18 lines
42 lines
8 lines
30 lines
33 lines

Diff 30571

View Options

keyserver/src/shared/state-sync/state-sync-spec.js

Loading...
View Options

lib/selectors/socket-selectors.js

Loading...
View Options

lib/shared/state-sync/current-user-state-sync-spec.js

Loading...
View Options

lib/shared/state-sync/entries-state-sync-spec.js

Loading...
View Options

lib/shared/state-sync/state-sync-spec.js

Loading...
View Options

lib/shared/state-sync/threads-state-sync-spec.js

Loading...
View Options

lib/shared/state-sync/users-state-sync-spec.js

Loading...