Choose the right spec and based on that an info and compute a hash for it.
https://linear.app/comm/issue/ENG-4813/migrate-getclientresponsesselector-to-a-spec
Depends on D9031
Details
Details
Modify server state and check if state check fixes client state.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- state-sync
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/selectors/socket-selectors.js | ||
|---|---|---|
| 125–129 | Entry info handling was a bit different than the other ones, but it didn't have to - the difference was that we were converting to serverEntryInfo, but this conversion was done earlier (now in stateSyncSpecs.entries.convertClientToServerInfos). The second conversion (here) was redundant and can be safely omitted. | |
| lib/selectors/socket-selectors.js | ||
|---|---|---|
| 125–127 | A condition where innerSpec isn't present corresponds to the else clause in the original code - we're keeping the same behavior by continuing the loop (it is important because it lets us introduce new state syncs without breaking older clients). | |
| lib/selectors/socket-selectors.js | ||
|---|---|---|
| 114 | ||
| lib/selectors/socket-selectors.js | ||
|---|---|---|
| 114 | Flow isn't that smart
| |