[lib] Refactor the remaining part of the hash logic using specs
ClosedPublic
Actions

Authored by tomek on Aug 31 2023, 8:35 AM.

Details

Reviewers

kamil
bartek
inka

Commits

rCOMM0a98395dfdab: [lib] Refactor the remaining part of the hash logic using specs

Summary

We can iterate over specs and use the same logic which was used for each infos collection.

https://linear.app/comm/issue/ENG-4813/migrate-getclientresponsesselector-to-a-spec

Depends on D9048

Test Plan

Modify server state and check if state check fixes client state. Bring back the old implementation and check if the hashResults are the same.

Diff Detail

Repository

rCOMM Comm

Branch

state-sync

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Aug 31 2023, 8:35 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 31 2023, 8:35 AM

Harbormaster completed remote builds in B22317: Diff 30658.Aug 31 2023, 8:53 AM

tomek requested review of this revision.Aug 31 2023, 8:53 AM

kamil accepted this revision.Sep 4 2023, 5:12 AM

This revision is now accepted and ready to land.Sep 4 2023, 5:12 AM

tomek added a child revision: D9081: [keyserver] Handle new session state sync.Sep 5 2023, 5:15 AM

Closed by commit rCOMM0a98395dfdab: [lib] Refactor the remaining part of the hash logic using specs (authored by tomek). · Explain WhySep 5 2023, 7:03 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM0a98395dfdab: [lib] Refactor the remaining part of the hash logic using specs.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

socket-selectors.js

30 lines

Diff 30658

View Options

lib/selectors/socket-selectors.js

[lib] Refactor the remaining part of the hash logic using specsClosedPublicActions