Differential D9086

[keyserver] Read calendar query directly from viewer.
ClosedPublic
Actions

Authored by tomek on Sep 5 2023, 8:31 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 4:00 PM

	Unknown Object (File)
	Sun, Nov 10, 4:00 PM

	Unknown Object (File)
	Sun, Nov 10, 3:58 PM

	Unknown Object (File)
	Tue, Nov 5, 2:12 AM

	Unknown Object (File)
	Wed, Oct 23, 1:29 AM

	Unknown Object (File)
	Mon, Oct 21, 5:05 AM

	Unknown Object (File)
	Oct 12 2024, 2:04 AM

	Unknown Object (File)
	Oct 1 2024, 11:01 PM

View All 74 Files

Subscribers

Details

Reviewers

kamil
bartek
inka

Commits

rCOMMa544318ebcdb: [keyserver] Read calendar query directly from viewer.

Summary

We were providing calendar query to a fetch from a spec as a separate parameter. Each time a value for this parameter was computed, it was taken from the viewer object. It means that we can simplify the code by reading the query inside specs that need it.

https://linear.app/comm/issue/ENG-4822/consider-using-calendarquery-from-viewer-inside-state-sync-specs

Depends on D9081

Test Plan

Modify server state and check if state check fixes client state.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Sep 5 2023, 8:31 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 5 2023, 8:31 AM

Harbormaster completed remote builds in B22390: Diff 30779.Sep 5 2023, 8:49 AM

tomek requested review of this revision.Sep 5 2023, 8:49 AM

kamil accepted this revision.Sep 7 2023, 5:58 AM

This revision is now accepted and ready to land.Sep 7 2023, 5:58 AM

Closed by commit rCOMMa544318ebcdb: [keyserver] Read calendar query directly from viewer. (authored by tomek). · Explain WhySep 7 2023, 7:28 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMa544318ebcdb: [keyserver] Read calendar query directly from viewer..

Revision Contents
Changeset List

Path

Size

keyserver/

src/

shared/

state-sync/

entries-state-sync-spec.js

7 lines

state-sync-spec.js

6 lines

threads-state-sync-spec.js

7 lines

users-state-sync-spec.js

7 lines

socket/

session-utils.js

7 lines

9 lines

Diff 30835

keyserver/src/shared/state-sync/entries-state-sync-spec.js

Loading...

keyserver/src/shared/state-sync/state-sync-spec.js

Loading...

keyserver/src/shared/state-sync/threads-state-sync-spec.js

Loading...

keyserver/src/shared/state-sync/users-state-sync-spec.js

Loading...

keyserver/src/socket/session-utils.js

Loading...

keyserver/src/socket/socket.js

Loading...