Move the logic from a reducer to specs.
Depends on D9244
Details
Details
Open two clients and check if making operations (e.g. updating or joining a thread) generates the right ops on the other.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/reducers/thread-reducer.js | ||
|---|---|---|
| 70–80 ↗ | (On Diff #31310) | I think this can be simplified to return payload.updatesResult.newUpdates.map(update => ... ).filter(Boolean).flat(); |
| lib/shared/updates/update-thread-read-status-spec.js | ||
| 17–20 ↗ | (On Diff #31310) | nit: I think negation of this condition and early exit is more readable |
Comment Actions
Add early return and use more functional approach
| lib/reducers/thread-reducer.js | ||
|---|---|---|
| 70–80 ↗ | (On Diff #31310) | Initially, I used a similar approach to what you propose, but Flow was complaining about it. Now I tried it again, and it seems to work. |