Move the code and do required changes in some types.
Depends on D9319
https://linear.app/comm/issue/ENG-4677/describe-inconsistencies-as-a-part-of-a-spec
Paths
| Differential D9354 Authored by tomek on Oct 4 2023, 3:19 AM.
Details Summary Move the code and do required changes in some types. Depends on D9319 https://linear.app/comm/issue/ENG-4677/describe-inconsistencies-as-a-part-of-a-spec Test Plan Added console logs in the reports reducer and in the user reducer. Modified server state and checked if state sync generates a report.
Diff Detail
Event TimelineHerald added a subscriber: will. · View Herald TranscriptOct 4 2023, 3:19 AM2023-10-04 03:19:37 (UTC-7)
Harbormaster completed remote builds in B22962: Diff 31626.Oct 4 2023, 3:37 AM2023-10-04 03:37:26 (UTC-7) Harbormaster completed remote builds in B22963: Diff 31627.Oct 4 2023, 3:42 AM2023-10-04 03:42:02 (UTC-7) tomek edited the test plan for this revision. (Show Details)Oct 5 2023, 4:25 AM2023-10-05 04:25:00 (UTC-7) This revision is now accepted and ready to land.Oct 5 2023, 5:25 AM2023-10-05 05:25:26 (UTC-7) Comment Actions
On the other hand, when you return the result we should allow the caller to do and modify the result, not sure what is better in this use case. Comment Actions
It seems like in this case we definitely should return a read-only type. When there are no inconsistencies, we return the same reference and we don't want it to be modified by anyone. Harbormaster failed remote builds in B23080: Diff 31773!Oct 9 2023, 3:33 AM2023-10-09 03:33:39 (UTC-7) Harbormaster completed remote builds in B23081: Diff 31774.Oct 9 2023, 3:38 AM2023-10-09 03:38:54 (UTC-7) Closed by commit rCOMMcd01c1732bd6: [lib] Move inconsistencies finding into specs (authored by tomek). · Explain WhyOct 9 2023, 3:57 AM2023-10-09 03:57:41 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 31783 keyserver/src/shared/state-sync/current-user-state-sync-spec.js
keyserver/src/shared/state-sync/entries-state-sync-spec.js
keyserver/src/shared/state-sync/state-sync-spec.js
keyserver/src/shared/state-sync/state-sync-specs.js
keyserver/src/shared/state-sync/threads-state-sync-spec.js
|