Page MenuHomePhabricator

[keyserver] Move update delete condition to a spec
ClosedPublic

Authored by tomek on Oct 31 2023, 8:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 8:12 AM
Unknown Object (File)
Fri, Nov 15, 2:04 AM
Unknown Object (File)
Thu, Nov 14, 10:13 PM
Unknown Object (File)
Fri, Nov 1, 4:32 AM
Unknown Object (File)
Fri, Nov 1, 3:47 AM
Unknown Object (File)
Oct 2 2024, 11:35 AM
Unknown Object (File)
Oct 2 2024, 11:35 AM
Unknown Object (File)
Oct 2 2024, 11:35 AM
Subscribers

Details

Summary

Add a field to a spec defining delete condition for a type.

Depends on D9657

Test Plan

Generate some updates, reintroduce old code, and compare new with old result using _.isEqual

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil added inline comments.
keyserver/src/creators/update-creator.js
72 ↗(On Diff #32558)

it's used twice, can we make a type alias?

This revision is now accepted and ready to land.Nov 2 2023, 9:37 AM