Page MenuHomePhabricator
Differential D9658

[keyserver] Move update delete condition to a spec
ClosedPublic
Actions

Authored by tomek on Oct 31 2023, 8:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 3:56 AM
Unknown Object (File)
Sat, Mar 1, 11:13 AM
Unknown Object (File)
Sat, Mar 1, 10:56 AM
Unknown Object (File)
Sat, Mar 1, 10:56 AM
Unknown Object (File)
Sat, Mar 1, 10:56 AM
Unknown Object (File)
Sat, Mar 1, 9:35 AM
Unknown Object (File)
Jan 31 2025, 4:11 PM
Unknown Object (File)
Jan 31 2025, 4:11 PM
View All 92 Files
Subscribers
ashoat
will

Details

Reviewers
kamil
inka
bartek
Commits
rCOMMeeed0650fd0b: [keyserver] Move update delete condition to a spec
Summary

Add a field to a spec defining delete condition for a type.

Depends on D9657

Test Plan

Generate some updates, reintroduce old code, and compare new with old result using _.isEqual

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 32558

View Options

keyserver/src/creators/update-creator.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
changeThreadMemberRoles, changeThreadMemberRoles,
changeThreadMemberRolesActionTypes, changeThreadMemberRolesActionTypes,
} from 'lib/actions/thread-actions.js'; } from 'lib/actions/thread-actions.js';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { otherUsersButNoOtherAdmins } from 'lib/selectors/thread-selectors.js';
import { roleIsAdminRole } from 'lib/shared/thread-utils.js';
import type { RelativeMemberInfo, ThreadInfo } from 'lib/types/thread-types'; import type { RelativeMemberInfo, ThreadInfo } from 'lib/types/thread-types';
import { import {
useDispatchActionPromise, useDispatchActionPromise,
useServerCall, useServerCall,
} from 'lib/utils/action-utils.js'; } from 'lib/utils/action-utils.js';
import { values } from 'lib/utils/objects.js'; import { values } from 'lib/utils/objects.js';
import css from './change-member-role-modal.css'; import css from './change-member-role-modal.css';
import Button, { buttonThemes } from '../../../components/button.react.js'; import Button, { buttonThemes } from '../../../components/button.react.js';
import Dropdown from '../../../components/dropdown.react.js'; import Dropdown from '../../../components/dropdown.react.js';
import UserAvatar from '../../../components/user-avatar.react.js'; import UserAvatar from '../../../components/user-avatar.react.js';
import { useSelector } from '../../../redux/redux-utils.js';
import Modal from '../../modal.react.js'; import Modal from '../../modal.react.js';
import UnsavedChangesModal from '../../unsaved-changes-modal.react.js'; import UnsavedChangesModal from '../../unsaved-changes-modal.react.js';
type ChangeMemberRoleModalProps = { type ChangeMemberRoleModalProps = {
+memberInfo: RelativeMemberInfo, +memberInfo: RelativeMemberInfo,
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ChangeMemberRoleModal(props: ChangeMemberRoleModalProps): React.Node { function ChangeMemberRoleModal(props: ChangeMemberRoleModalProps): React.Node {
const { memberInfo, threadInfo } = props; const { memberInfo, threadInfo } = props;
const { pushModal, popModal } = useModalContext(); const { pushModal, popModal } = useModalContext();
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callChangeThreadMemberRoles = useServerCall(changeThreadMemberRoles); const callChangeThreadMemberRoles = useServerCall(changeThreadMemberRoles);
const [showErrorMessage, setShowErrorMessage] = React.useState(false);
const otherUsersButNoOtherAdminsValue = useSelector(
otherUsersButNoOtherAdmins(threadInfo.id),
);
const roleOptions = React.useMemo( const roleOptions = React.useMemo(
() => () =>
values(threadInfo.roles).map(role => ({ values(threadInfo.roles).map(role => ({
id: role.id, id: role.id,
name: role.name, name: role.name,
})), })),
[threadInfo.roles], [threadInfo.roles],
Show All 13 Lines const onBackClick = React.useCallback(() => {
if (selectedRole === initialSelectedRole) { if (selectedRole === initialSelectedRole) {
popModal(); popModal();
return; return;
} }
pushModal(<UnsavedChangesModal />); pushModal(<UnsavedChangesModal />);
}, [initialSelectedRole, popModal, pushModal, selectedRole]); }, [initialSelectedRole, popModal, pushModal, selectedRole]);
const errorMessage = React.useMemo(() => {
if (!showErrorMessage) {
return null;
}
return (
<>
<div className={css.roleModalErrorMessage}>Cannot change role.</div>
<div className={css.roleModalErrorMessage}>
There must be at least one admin at any given time.
</div>
</>
);
}, [showErrorMessage]);
const onSave = React.useCallback(() => { const onSave = React.useCallback(() => {
if (selectedRole === initialSelectedRole) { if (selectedRole === initialSelectedRole) {
popModal(); popModal();
return; return;
} }
const memberIsAdmin = memberInfo.role
? roleIsAdminRole(threadInfo.roles[memberInfo.role])
: true;
// Handle case where the sole admin's role is being changed.
if (otherUsersButNoOtherAdminsValue && memberIsAdmin) {
setShowErrorMessage(true);
return;
}
setShowErrorMessage(false);
const createChangeThreadMemberRolesPromise = () => { const createChangeThreadMemberRolesPromise = () => {
invariant(selectedRole, 'Expected selected role to be set'); invariant(selectedRole, 'Expected selected role to be set');
return callChangeThreadMemberRoles( return callChangeThreadMemberRoles(
threadInfo.id, threadInfo.id,
[memberInfo.id], [memberInfo.id],
selectedRole, selectedRole,
); );
}; };
dispatchActionPromise( dispatchActionPromise(
changeThreadMemberRolesActionTypes, changeThreadMemberRolesActionTypes,
createChangeThreadMemberRolesPromise(), createChangeThreadMemberRolesPromise(),
); );
popModal(); popModal();
}, [ }, [
callChangeThreadMemberRoles, callChangeThreadMemberRoles,
otherUsersButNoOtherAdminsValue,
dispatchActionPromise, dispatchActionPromise,
initialSelectedRole, initialSelectedRole,
memberInfo.id, memberInfo,
popModal, popModal,
selectedRole, selectedRole,
threadInfo.id, threadInfo,
]); ]);
return ( return (
<Modal name="Change Role" onClose={popModal} size="large"> <Modal name="Change Role" onClose={popModal} size="large">
<div className={css.roleModalDescription}> <div className={css.roleModalDescription}>
Members can only be assigned to one role at a time. Changing a Members can only be assigned to one role at a time. Changing a
member&rsquo;s role will replace their previously assigned role. member&rsquo;s role will replace their previously assigned role.
</div> </div>
<div className={css.roleModalMember}> <div className={css.roleModalMember}>
<div className={css.roleModalMemberAvatar}> <div className={css.roleModalMemberAvatar}>
<UserAvatar userID={memberInfo.id} size="large" /> <UserAvatar userID={memberInfo.id} size="large" />
</div> </div>
<div className={css.roleModalMemberName}>{memberInfo.username}</div> <div className={css.roleModalMemberName}>{memberInfo.username}</div>
</div> </div>
<div className={css.roleModalRoleSelector}> <div className={css.roleModalRoleSelector}>
<Dropdown <Dropdown
options={roleOptions} options={roleOptions}
activeSelection={selectedRole} activeSelection={selectedRole}
setActiveSelection={setSelectedRole} setActiveSelection={setSelectedRole}
/> />
</div> </div>
{errorMessage}
<div className={css.roleModalActionButtons}> <div className={css.roleModalActionButtons}>
<Button <Button
variant="outline" variant="outline"
className={css.roleModalBackButton} className={css.roleModalBackButton}
onClick={onBackClick} onClick={onBackClick}
> >
Back Back
</Button> </Button>
Show All 14 Lines
View Options

lib/shared/updates/bad-device-token-spec.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
changeThreadMemberRoles, changeThreadMemberRoles,
changeThreadMemberRolesActionTypes, changeThreadMemberRolesActionTypes,
} from 'lib/actions/thread-actions.js'; } from 'lib/actions/thread-actions.js';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { otherUsersButNoOtherAdmins } from 'lib/selectors/thread-selectors.js';
import { roleIsAdminRole } from 'lib/shared/thread-utils.js';
import type { RelativeMemberInfo, ThreadInfo } from 'lib/types/thread-types'; import type { RelativeMemberInfo, ThreadInfo } from 'lib/types/thread-types';
import { import {
useDispatchActionPromise, useDispatchActionPromise,
useServerCall, useServerCall,
} from 'lib/utils/action-utils.js'; } from 'lib/utils/action-utils.js';
import { values } from 'lib/utils/objects.js'; import { values } from 'lib/utils/objects.js';
import css from './change-member-role-modal.css'; import css from './change-member-role-modal.css';
import Button, { buttonThemes } from '../../../components/button.react.js'; import Button, { buttonThemes } from '../../../components/button.react.js';
import Dropdown from '../../../components/dropdown.react.js'; import Dropdown from '../../../components/dropdown.react.js';
import UserAvatar from '../../../components/user-avatar.react.js'; import UserAvatar from '../../../components/user-avatar.react.js';
import { useSelector } from '../../../redux/redux-utils.js';
import Modal from '../../modal.react.js'; import Modal from '../../modal.react.js';
import UnsavedChangesModal from '../../unsaved-changes-modal.react.js'; import UnsavedChangesModal from '../../unsaved-changes-modal.react.js';
type ChangeMemberRoleModalProps = { type ChangeMemberRoleModalProps = {
+memberInfo: RelativeMemberInfo, +memberInfo: RelativeMemberInfo,
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ChangeMemberRoleModal(props: ChangeMemberRoleModalProps): React.Node { function ChangeMemberRoleModal(props: ChangeMemberRoleModalProps): React.Node {
const { memberInfo, threadInfo } = props; const { memberInfo, threadInfo } = props;
const { pushModal, popModal } = useModalContext(); const { pushModal, popModal } = useModalContext();
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callChangeThreadMemberRoles = useServerCall(changeThreadMemberRoles); const callChangeThreadMemberRoles = useServerCall(changeThreadMemberRoles);
const [showErrorMessage, setShowErrorMessage] = React.useState(false);
const otherUsersButNoOtherAdminsValue = useSelector(
otherUsersButNoOtherAdmins(threadInfo.id),
);
const roleOptions = React.useMemo( const roleOptions = React.useMemo(
() => () =>
values(threadInfo.roles).map(role => ({ values(threadInfo.roles).map(role => ({
id: role.id, id: role.id,
name: role.name, name: role.name,
})), })),
[threadInfo.roles], [threadInfo.roles],
Show All 13 Lines const onBackClick = React.useCallback(() => {
if (selectedRole === initialSelectedRole) { if (selectedRole === initialSelectedRole) {
popModal(); popModal();
return; return;
} }
pushModal(<UnsavedChangesModal />); pushModal(<UnsavedChangesModal />);
}, [initialSelectedRole, popModal, pushModal, selectedRole]); }, [initialSelectedRole, popModal, pushModal, selectedRole]);
const errorMessage = React.useMemo(() => {
if (!showErrorMessage) {
return null;
}
return (
<>
<div className={css.roleModalErrorMessage}>Cannot change role.</div>
<div className={css.roleModalErrorMessage}>
There must be at least one admin at any given time.
</div>
</>
);
}, [showErrorMessage]);
const onSave = React.useCallback(() => { const onSave = React.useCallback(() => {
if (selectedRole === initialSelectedRole) { if (selectedRole === initialSelectedRole) {
popModal(); popModal();
return; return;
} }
const memberIsAdmin = memberInfo.role
? roleIsAdminRole(threadInfo.roles[memberInfo.role])
: true;
// Handle case where the sole admin's role is being changed.
if (otherUsersButNoOtherAdminsValue && memberIsAdmin) {
setShowErrorMessage(true);
return;
}
setShowErrorMessage(false);
const createChangeThreadMemberRolesPromise = () => { const createChangeThreadMemberRolesPromise = () => {
invariant(selectedRole, 'Expected selected role to be set'); invariant(selectedRole, 'Expected selected role to be set');
return callChangeThreadMemberRoles( return callChangeThreadMemberRoles(
threadInfo.id, threadInfo.id,
[memberInfo.id], [memberInfo.id],
selectedRole, selectedRole,
); );
}; };
dispatchActionPromise( dispatchActionPromise(
changeThreadMemberRolesActionTypes, changeThreadMemberRolesActionTypes,
createChangeThreadMemberRolesPromise(), createChangeThreadMemberRolesPromise(),
); );
popModal(); popModal();
}, [ }, [
callChangeThreadMemberRoles, callChangeThreadMemberRoles,
otherUsersButNoOtherAdminsValue,
dispatchActionPromise, dispatchActionPromise,
initialSelectedRole, initialSelectedRole,
memberInfo.id, memberInfo,
popModal, popModal,
selectedRole, selectedRole,
threadInfo.id, threadInfo,
]); ]);
return ( return (
<Modal name="Change Role" onClose={popModal} size="large"> <Modal name="Change Role" onClose={popModal} size="large">
<div className={css.roleModalDescription}> <div className={css.roleModalDescription}>
Members can only be assigned to one role at a time. Changing a Members can only be assigned to one role at a time. Changing a
member&rsquo;s role will replace their previously assigned role. member&rsquo;s role will replace their previously assigned role.
</div> </div>
<div className={css.roleModalMember}> <div className={css.roleModalMember}>
<div className={css.roleModalMemberAvatar}> <div className={css.roleModalMemberAvatar}>
<UserAvatar userID={memberInfo.id} size="large" /> <UserAvatar userID={memberInfo.id} size="large" />
</div> </div>
<div className={css.roleModalMemberName}>{memberInfo.username}</div> <div className={css.roleModalMemberName}>{memberInfo.username}</div>
</div> </div>
<div className={css.roleModalRoleSelector}> <div className={css.roleModalRoleSelector}>
<Dropdown <Dropdown
options={roleOptions} options={roleOptions}
activeSelection={selectedRole} activeSelection={selectedRole}
setActiveSelection={setSelectedRole} setActiveSelection={setSelectedRole}
/> />
</div> </div>
{errorMessage}
<div className={css.roleModalActionButtons}> <div className={css.roleModalActionButtons}>
<Button <Button
variant="outline" variant="outline"
className={css.roleModalBackButton} className={css.roleModalBackButton}
onClick={onBackClick} onClick={onBackClick}
> >
Back Back
</Button> </Button>
Show All 14 Lines
View Options

lib/shared/updates/delete-account-spec.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
changeThreadMemberRoles, changeThreadMemberRoles,
changeThreadMemberRolesActionTypes, changeThreadMemberRolesActionTypes,
} from 'lib/actions/thread-actions.js'; } from 'lib/actions/thread-actions.js';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { otherUsersButNoOtherAdmins } from 'lib/selectors/thread-selectors.js';
import { roleIsAdminRole } from 'lib/shared/thread-utils.js';
import type { RelativeMemberInfo, ThreadInfo } from 'lib/types/thread-types'; import type { RelativeMemberInfo, ThreadInfo } from 'lib/types/thread-types';
import { import {
useDispatchActionPromise, useDispatchActionPromise,
useServerCall, useServerCall,
} from 'lib/utils/action-utils.js'; } from 'lib/utils/action-utils.js';
import { values } from 'lib/utils/objects.js'; import { values } from 'lib/utils/objects.js';
import css from './change-member-role-modal.css'; import css from './change-member-role-modal.css';
import Button, { buttonThemes } from '../../../components/button.react.js'; import Button, { buttonThemes } from '../../../components/button.react.js';
import Dropdown from '../../../components/dropdown.react.js'; import Dropdown from '../../../components/dropdown.react.js';
import UserAvatar from '../../../components/user-avatar.react.js'; import UserAvatar from '../../../components/user-avatar.react.js';
import { useSelector } from '../../../redux/redux-utils.js';
import Modal from '../../modal.react.js'; import Modal from '../../modal.react.js';
import UnsavedChangesModal from '../../unsaved-changes-modal.react.js'; import UnsavedChangesModal from '../../unsaved-changes-modal.react.js';
type ChangeMemberRoleModalProps = { type ChangeMemberRoleModalProps = {
+memberInfo: RelativeMemberInfo, +memberInfo: RelativeMemberInfo,
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ChangeMemberRoleModal(props: ChangeMemberRoleModalProps): React.Node { function ChangeMemberRoleModal(props: ChangeMemberRoleModalProps): React.Node {
const { memberInfo, threadInfo } = props; const { memberInfo, threadInfo } = props;
const { pushModal, popModal } = useModalContext(); const { pushModal, popModal } = useModalContext();
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callChangeThreadMemberRoles = useServerCall(changeThreadMemberRoles); const callChangeThreadMemberRoles = useServerCall(changeThreadMemberRoles);
const [showErrorMessage, setShowErrorMessage] = React.useState(false);
const otherUsersButNoOtherAdminsValue = useSelector(
otherUsersButNoOtherAdmins(threadInfo.id),
);
const roleOptions = React.useMemo( const roleOptions = React.useMemo(
() => () =>
values(threadInfo.roles).map(role => ({ values(threadInfo.roles).map(role => ({
id: role.id, id: role.id,
name: role.name, name: role.name,
})), })),
[threadInfo.roles], [threadInfo.roles],
Show All 13 Lines const onBackClick = React.useCallback(() => {
if (selectedRole === initialSelectedRole) { if (selectedRole === initialSelectedRole) {
popModal(); popModal();
return; return;
} }
pushModal(<UnsavedChangesModal />); pushModal(<UnsavedChangesModal />);
}, [initialSelectedRole, popModal, pushModal, selectedRole]); }, [initialSelectedRole, popModal, pushModal, selectedRole]);
const errorMessage = React.useMemo(() => {
if (!showErrorMessage) {
return null;
}
return (
<>
<div className={css.roleModalErrorMessage}>Cannot change role.</div>
<div className={css.roleModalErrorMessage}>
There must be at least one admin at any given time.
</div>
</>
);
}, [showErrorMessage]);
const onSave = React.useCallback(() => { const onSave = React.useCallback(() => {
if (selectedRole === initialSelectedRole) { if (selectedRole === initialSelectedRole) {
popModal(); popModal();
return; return;
} }
const memberIsAdmin = memberInfo.role
? roleIsAdminRole(threadInfo.roles[memberInfo.role])
: true;
// Handle case where the sole admin's role is being changed.
if (otherUsersButNoOtherAdminsValue && memberIsAdmin) {
setShowErrorMessage(true);
return;
}
setShowErrorMessage(false);
const createChangeThreadMemberRolesPromise = () => { const createChangeThreadMemberRolesPromise = () => {
invariant(selectedRole, 'Expected selected role to be set'); invariant(selectedRole, 'Expected selected role to be set');
return callChangeThreadMemberRoles( return callChangeThreadMemberRoles(
threadInfo.id, threadInfo.id,
[memberInfo.id], [memberInfo.id],
selectedRole, selectedRole,
); );
}; };
dispatchActionPromise( dispatchActionPromise(
changeThreadMemberRolesActionTypes, changeThreadMemberRolesActionTypes,
createChangeThreadMemberRolesPromise(), createChangeThreadMemberRolesPromise(),
); );
popModal(); popModal();
}, [ }, [
callChangeThreadMemberRoles, callChangeThreadMemberRoles,
otherUsersButNoOtherAdminsValue,
dispatchActionPromise, dispatchActionPromise,
initialSelectedRole, initialSelectedRole,
memberInfo.id, memberInfo,
popModal, popModal,
selectedRole, selectedRole,
threadInfo.id, threadInfo,
]); ]);
return ( return (
<Modal name="Change Role" onClose={popModal} size="large"> <Modal name="Change Role" onClose={popModal} size="large">
<div className={css.roleModalDescription}> <div className={css.roleModalDescription}>
Members can only be assigned to one role at a time. Changing a Members can only be assigned to one role at a time. Changing a
member&rsquo;s role will replace their previously assigned role. member&rsquo;s role will replace their previously assigned role.
</div> </div>
<div className={css.roleModalMember}> <div className={css.roleModalMember}>
<div className={css.roleModalMemberAvatar}> <div className={css.roleModalMemberAvatar}>
<UserAvatar userID={memberInfo.id} size="large" /> <UserAvatar userID={memberInfo.id} size="large" />
</div> </div>
<div className={css.roleModalMemberName}>{memberInfo.username}</div> <div className={css.roleModalMemberName}>{memberInfo.username}</div>
</div> </div>
<div className={css.roleModalRoleSelector}> <div className={css.roleModalRoleSelector}>
<Dropdown <Dropdown
options={roleOptions} options={roleOptions}
activeSelection={selectedRole} activeSelection={selectedRole}
setActiveSelection={setSelectedRole} setActiveSelection={setSelectedRole}
/> />
</div> </div>
{errorMessage}
<div className={css.roleModalActionButtons}> <div className={css.roleModalActionButtons}>
<Button <Button
variant="outline" variant="outline"
className={css.roleModalBackButton} className={css.roleModalBackButton}
onClick={onBackClick} onClick={onBackClick}
> >
Back Back
</Button> </Button>
Show All 14 Lines
View Options

lib/shared/updates/delete-thread-spec.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
changeThreadMemberRoles, changeThreadMemberRoles,
changeThreadMemberRolesActionTypes, changeThreadMemberRolesActionTypes,
} from 'lib/actions/thread-actions.js'; } from 'lib/actions/thread-actions.js';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { otherUsersButNoOtherAdmins } from 'lib/selectors/thread-selectors.js';
import { roleIsAdminRole } from 'lib/shared/thread-utils.js';
import type { RelativeMemberInfo, ThreadInfo } from 'lib/types/thread-types'; import type { RelativeMemberInfo, ThreadInfo } from 'lib/types/thread-types';
import { import {
useDispatchActionPromise, useDispatchActionPromise,
useServerCall, useServerCall,
} from 'lib/utils/action-utils.js'; } from 'lib/utils/action-utils.js';
import { values } from 'lib/utils/objects.js'; import { values } from 'lib/utils/objects.js';
import css from './change-member-role-modal.css'; import css from './change-member-role-modal.css';
import Button, { buttonThemes } from '../../../components/button.react.js'; import Button, { buttonThemes } from '../../../components/button.react.js';
import Dropdown from '../../../components/dropdown.react.js'; import Dropdown from '../../../components/dropdown.react.js';
import UserAvatar from '../../../components/user-avatar.react.js'; import UserAvatar from '../../../components/user-avatar.react.js';
import { useSelector } from '../../../redux/redux-utils.js';
import Modal from '../../modal.react.js'; import Modal from '../../modal.react.js';
import UnsavedChangesModal from '../../unsaved-changes-modal.react.js'; import UnsavedChangesModal from '../../unsaved-changes-modal.react.js';
type ChangeMemberRoleModalProps = { type ChangeMemberRoleModalProps = {
+memberInfo: RelativeMemberInfo, +memberInfo: RelativeMemberInfo,
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ChangeMemberRoleModal(props: ChangeMemberRoleModalProps): React.Node { function ChangeMemberRoleModal(props: ChangeMemberRoleModalProps): React.Node {
const { memberInfo, threadInfo } = props; const { memberInfo, threadInfo } = props;
const { pushModal, popModal } = useModalContext(); const { pushModal, popModal } = useModalContext();
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callChangeThreadMemberRoles = useServerCall(changeThreadMemberRoles); const callChangeThreadMemberRoles = useServerCall(changeThreadMemberRoles);
const [showErrorMessage, setShowErrorMessage] = React.useState(false);
const otherUsersButNoOtherAdminsValue = useSelector(
otherUsersButNoOtherAdmins(threadInfo.id),
);
const roleOptions = React.useMemo( const roleOptions = React.useMemo(
() => () =>
values(threadInfo.roles).map(role => ({ values(threadInfo.roles).map(role => ({
id: role.id, id: role.id,
name: role.name, name: role.name,
})), })),
[threadInfo.roles], [threadInfo.roles],
Show All 13 Lines const onBackClick = React.useCallback(() => {
if (selectedRole === initialSelectedRole) { if (selectedRole === initialSelectedRole) {
popModal(); popModal();
return; return;
} }
pushModal(<UnsavedChangesModal />); pushModal(<UnsavedChangesModal />);
}, [initialSelectedRole, popModal, pushModal, selectedRole]); }, [initialSelectedRole, popModal, pushModal, selectedRole]);
const errorMessage = React.useMemo(() => {
if (!showErrorMessage) {
return null;
}
return (
<>
<div className={css.roleModalErrorMessage}>Cannot change role.</div>
<div className={css.roleModalErrorMessage}>
There must be at least one admin at any given time.
</div>
</>
);
}, [showErrorMessage]);
const onSave = React.useCallback(() => { const onSave = React.useCallback(() => {
if (selectedRole === initialSelectedRole) { if (selectedRole === initialSelectedRole) {
popModal(); popModal();
return; return;
} }
const memberIsAdmin = memberInfo.role
? roleIsAdminRole(threadInfo.roles[memberInfo.role])
: true;
// Handle case where the sole admin's role is being changed.
if (otherUsersButNoOtherAdminsValue && memberIsAdmin) {
setShowErrorMessage(true);
return;
}
setShowErrorMessage(false);
const createChangeThreadMemberRolesPromise = () => { const createChangeThreadMemberRolesPromise = () => {
invariant(selectedRole, 'Expected selected role to be set'); invariant(selectedRole, 'Expected selected role to be set');
return callChangeThreadMemberRoles( return callChangeThreadMemberRoles(
threadInfo.id, threadInfo.id,
[memberInfo.id], [memberInfo.id],
selectedRole, selectedRole,
); );
}; };
dispatchActionPromise( dispatchActionPromise(
changeThreadMemberRolesActionTypes, changeThreadMemberRolesActionTypes,
createChangeThreadMemberRolesPromise(), createChangeThreadMemberRolesPromise(),
); );
popModal(); popModal();
}, [ }, [
callChangeThreadMemberRoles, callChangeThreadMemberRoles,
otherUsersButNoOtherAdminsValue,
dispatchActionPromise, dispatchActionPromise,
initialSelectedRole, initialSelectedRole,
memberInfo.id, memberInfo,
popModal, popModal,
selectedRole, selectedRole,
threadInfo.id, threadInfo,
]); ]);
return ( return (
<Modal name="Change Role" onClose={popModal} size="large"> <Modal name="Change Role" onClose={popModal} size="large">
<div className={css.roleModalDescription}> <div className={css.roleModalDescription}>
Members can only be assigned to one role at a time. Changing a Members can only be assigned to one role at a time. Changing a
member&rsquo;s role will replace their previously assigned role. member&rsquo;s role will replace their previously assigned role.
</div> </div>
<div className={css.roleModalMember}> <div className={css.roleModalMember}>
<div className={css.roleModalMemberAvatar}> <div className={css.roleModalMemberAvatar}>
<UserAvatar userID={memberInfo.id} size="large" /> <UserAvatar userID={memberInfo.id} size="large" />
</div> </div>
<div className={css.roleModalMemberName}>{memberInfo.username}</div> <div className={css.roleModalMemberName}>{memberInfo.username}</div>
</div> </div>
<div className={css.roleModalRoleSelector}> <div className={css.roleModalRoleSelector}>
<Dropdown <Dropdown
options={roleOptions} options={roleOptions}
activeSelection={selectedRole} activeSelection={selectedRole}
setActiveSelection={setSelectedRole} setActiveSelection={setSelectedRole}
/> />
</div> </div>
{errorMessage}
<div className={css.roleModalActionButtons}> <div className={css.roleModalActionButtons}>
<Button <Button
variant="outline" variant="outline"
className={css.roleModalBackButton} className={css.roleModalBackButton}
onClick={onBackClick} onClick={onBackClick}
> >
Back Back
</Button> </Button>
Show All 14 Lines
View Options

lib/shared/updates/join-thread-spec.js

Loading...
View Options

lib/shared/updates/update-current-user-spec.js

Loading...
View Options

lib/shared/updates/update-entry-spec.js

Loading...
View Options

lib/shared/updates/update-spec.js

Loading...
View Options

lib/shared/updates/update-thread-read-status-spec.js

Loading...
View Options

lib/shared/updates/update-thread-spec.js

Loading...
View Options

lib/shared/updates/update-user-spec.js

Loading...