Paths

Table of Contentst

[keyserver] Move update delete condition to a spec
ClosedPublic
Actions

Authored by tomek on Oct 31 2023, 8:56 AM.

Details

Reviewers

kamil
inka
bartek

Commits

rCOMMeeed0650fd0b: [keyserver] Move update delete condition to a spec

Summary

Add a field to a spec defining delete condition for a type.

Depends on D9657

Test Plan

Generate some updates, reintroduce old code, and compare new with old result using _.isEqual

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Oct 31 2023, 8:56 AM

Herald added subscribers: will, ashoat. · View Herald TranscriptOct 31 2023, 8:56 AM

tomek added a child revision: D9659: [keyserver] Simplify updates merging.Oct 31 2023, 9:00 AM

Harbormaster completed remote builds in B23615: Diff 32558.Oct 31 2023, 10:02 AM

tomek requested review of this revision.Oct 31 2023, 10:02 AM

kamil accepted this revision.Nov 2 2023, 9:37 AM

kamil added inline comments.

keyserver/src/creators/update-creator.js
72	it's used twice, can we make a type alias?

This revision is now accepted and ready to land.Nov 2 2023, 9:37 AM

kamil mentioned this in D9660: [keyserver] Move merging of updates to a spec.Nov 3 2023, 2:54 AM

Create shared type

Harbormaster completed remote builds in B23785: Diff 32753.Nov 6 2023, 5:36 AM

Closed by commit rCOMMeeed0650fd0b: [keyserver] Move update delete condition to a spec (authored by tomek). · Explain WhyNov 6 2023, 6:59 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMeeed0650fd0b: [keyserver] Move update delete condition to a spec.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

update-creator.js

28 lines

lib/

shared/

updates/

bad-device-token-spec.js

1 line

delete-account-spec.js

4 lines

delete-thread-spec.js

1 line

join-thread-spec.js

1 line

update-current-user-spec.js

1 line

update-entry-spec.js

1 line

update-spec.js

2 lines

update-thread-read-status-spec.js

1 line

update-thread-spec.js

4 lines

update-user-spec.js

1 line

Diff 32558

View Options

keyserver/src/creators/update-creator.js

View Options

lib/shared/updates/bad-device-token-spec.js

View Options

lib/shared/updates/delete-account-spec.js

View Options

lib/shared/updates/delete-thread-spec.js

View Options

lib/shared/updates/join-thread-spec.js

View Options

lib/shared/updates/update-current-user-spec.js

View Options

lib/shared/updates/update-entry-spec.js

View Options

lib/shared/updates/update-spec.js

View Options

lib/shared/updates/update-thread-read-status-spec.js

View Options

lib/shared/updates/update-thread-spec.js

View Options

lib/shared/updates/update-user-spec.js

[keyserver] Move update delete condition to a specClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32558

keyserver/src/creators/update-creator.js

lib/shared/updates/bad-device-token-spec.js

lib/shared/updates/delete-account-spec.js

lib/shared/updates/delete-thread-spec.js

lib/shared/updates/join-thread-spec.js

lib/shared/updates/update-current-user-spec.js

lib/shared/updates/update-entry-spec.js

lib/shared/updates/update-spec.js

lib/shared/updates/update-thread-read-status-spec.js

lib/shared/updates/update-thread-spec.js

lib/shared/updates/update-user-spec.js

[keyserver] Move update delete condition to a spec
ClosedPublic
Actions

Revision Contents
Changeset List