Page MenuHomePhabricator
Differential D9318

[lib] Move local id update reducer into specs
ClosedPublic
Actions

Authored by tomek on Sep 28 2023, 8:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 22, 5:01 PM
Unknown Object (File)
Sat, Mar 1, 11:13 AM
Unknown Object (File)
Sat, Mar 1, 10:56 AM
Unknown Object (File)
Sat, Mar 1, 10:56 AM
Unknown Object (File)
Sat, Mar 1, 10:56 AM
Unknown Object (File)
Sat, Mar 1, 9:34 AM
Unknown Object (File)
Feb 17 2025, 6:26 PM
Unknown Object (File)
Jan 28 2025, 7:50 PM
View All Files
Subscribers
ashoat
michal

Details

Reviewers
kamil
bartek
inka
Commits
rCOMMc9a66b403e9d: [lib] Move local id update reducer into specs
Summary

Move getting raw messages to a spec.

Depends on D9315

https://linear.app/comm/issue/ENG-4241/handle-processupdatesactiontype-as-a-part-of-a-spec

Test Plan

Check if the new code produces the same result as the old one.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Sep 28 2023, 8:10 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 28 2023, 8:10 AM
tomek added a child revision: D9319: [lib] Move message update reducer into specs.Sep 28 2023, 8:24 AM
Harbormaster completed remote builds in B22897: Diff 31528.Sep 28 2023, 8:28 AM
tomek requested review of this revision.Sep 28 2023, 8:28 AM
kamil accepted this revision.Sep 29 2023, 4:01 AM
kamil added inline comments.
lib/reducers/local-id-reducer.js
115–123 ↗(On Diff #31528)

as previously, I prefer a more functional approach here than a loop but I am afraid Flow will complain

This revision is now accepted and ready to land.Sep 29 2023, 4:01 AM
tomek updated this revision to Diff 31615.Oct 3 2023, 7:30 AM

Use more functional approach

Harbormaster completed remote builds in B22952: Diff 31615.Oct 3 2023, 7:48 AM
Closed by commit rCOMMc9a66b403e9d: [lib] Move local id update reducer into specs (authored by tomek). · Explain WhyOct 9 2023, 3:57 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMc9a66b403e9d: [lib] Move local id update reducer into specs.

Revision Contents
Changeset List

PathSize
lib/
reducers/
16 lines
shared/
updates/
3 lines
2 lines

Diff 31781

View Options

lib/reducers/local-id-reducer.js

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import type { import type {
UserSearchRequest, UserSearchRequest,
UserSearchResult, UserSearchResult,
ExactUserSearchRequest,
ExactUserSearchResult,
} from 'lib/types/search-types.js'; } from 'lib/types/search-types.js';
import { globalAccountUserInfoValidator } from 'lib/types/user-types.js'; import { globalAccountUserInfoValidator } from 'lib/types/user-types.js';
import { tShape } from 'lib/utils/validation-utils.js'; import { tShape } from 'lib/utils/validation-utils.js';
import { searchForUsers } from '../search/users.js'; import { searchForUsers, searchForUser } from '../search/users.js';
import type { Viewer } from '../session/viewer.js'; import type { Viewer } from '../session/viewer.js';
import { validateInput, validateOutput } from '../utils/validation-utils.js'; import { validateInput, validateOutput } from '../utils/validation-utils.js';
const userSearchRequestInputValidator = tShape<UserSearchRequest>({ const userSearchRequestInputValidator = tShape<UserSearchRequest>({
prefix: t.maybe(t.String), prefix: t.maybe(t.String),
}); });
export const userSearchResultValidator: TInterface<UserSearchResult> = export const userSearchResultValidator: TInterface<UserSearchResult> =
Show All 14 Lines): Promise<UserSearchResult> {
const result = { userInfos: searchResults }; const result = { userInfos: searchResults };
return validateOutput( return validateOutput(
viewer.platformDetails, viewer.platformDetails,
userSearchResultValidator, userSearchResultValidator,
result, result,
); );
} }
export { userSearchResponder }; const exactUserSearchRequestInputValidator = tShape<ExactUserSearchRequest>({
username: t.String,
});
const exactUserSearchResultValidator = tShape<ExactUserSearchResult>({
userInfo: t.maybe(globalAccountUserInfoValidator),
});
async function exactUserSearchResponder(
viewer: Viewer,
input: mixed,
): Promise<ExactUserSearchResult> {
const request = await validateInput(
viewer,
exactUserSearchRequestInputValidator,
input,
);
const searchResult = await searchForUser(request.username);
const result = { userInfo: searchResult };
return validateOutput(
viewer.platformDetails,
exactUserSearchResultValidator,
result,
);
}
export { userSearchResponder, exactUserSearchResponder };
View Options

lib/shared/updates/join-thread-spec.js

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import type { import type {
UserSearchRequest, UserSearchRequest,
UserSearchResult, UserSearchResult,
ExactUserSearchRequest,
ExactUserSearchResult,
} from 'lib/types/search-types.js'; } from 'lib/types/search-types.js';
import { globalAccountUserInfoValidator } from 'lib/types/user-types.js'; import { globalAccountUserInfoValidator } from 'lib/types/user-types.js';
import { tShape } from 'lib/utils/validation-utils.js'; import { tShape } from 'lib/utils/validation-utils.js';
import { searchForUsers } from '../search/users.js'; import { searchForUsers, searchForUser } from '../search/users.js';
import type { Viewer } from '../session/viewer.js'; import type { Viewer } from '../session/viewer.js';
import { validateInput, validateOutput } from '../utils/validation-utils.js'; import { validateInput, validateOutput } from '../utils/validation-utils.js';
const userSearchRequestInputValidator = tShape<UserSearchRequest>({ const userSearchRequestInputValidator = tShape<UserSearchRequest>({
prefix: t.maybe(t.String), prefix: t.maybe(t.String),
}); });
export const userSearchResultValidator: TInterface<UserSearchResult> = export const userSearchResultValidator: TInterface<UserSearchResult> =
Show All 14 Lines): Promise<UserSearchResult> {
const result = { userInfos: searchResults }; const result = { userInfos: searchResults };
return validateOutput( return validateOutput(
viewer.platformDetails, viewer.platformDetails,
userSearchResultValidator, userSearchResultValidator,
result, result,
); );
} }
export { userSearchResponder }; const exactUserSearchRequestInputValidator = tShape<ExactUserSearchRequest>({
username: t.String,
});
const exactUserSearchResultValidator = tShape<ExactUserSearchResult>({
userInfo: t.maybe(globalAccountUserInfoValidator),
});
async function exactUserSearchResponder(
viewer: Viewer,
input: mixed,
): Promise<ExactUserSearchResult> {
const request = await validateInput(
viewer,
exactUserSearchRequestInputValidator,
input,
);
const searchResult = await searchForUser(request.username);
const result = { userInfo: searchResult };
return validateOutput(
viewer.platformDetails,
exactUserSearchResultValidator,
result,
);
}
export { userSearchResponder, exactUserSearchResponder };
View Options

lib/shared/updates/update-spec.js

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import type { import type {
UserSearchRequest, UserSearchRequest,
UserSearchResult, UserSearchResult,
ExactUserSearchRequest,
ExactUserSearchResult,
} from 'lib/types/search-types.js'; } from 'lib/types/search-types.js';
import { globalAccountUserInfoValidator } from 'lib/types/user-types.js'; import { globalAccountUserInfoValidator } from 'lib/types/user-types.js';
import { tShape } from 'lib/utils/validation-utils.js'; import { tShape } from 'lib/utils/validation-utils.js';
import { searchForUsers } from '../search/users.js'; import { searchForUsers, searchForUser } from '../search/users.js';
import type { Viewer } from '../session/viewer.js'; import type { Viewer } from '../session/viewer.js';
import { validateInput, validateOutput } from '../utils/validation-utils.js'; import { validateInput, validateOutput } from '../utils/validation-utils.js';
const userSearchRequestInputValidator = tShape<UserSearchRequest>({ const userSearchRequestInputValidator = tShape<UserSearchRequest>({
prefix: t.maybe(t.String), prefix: t.maybe(t.String),
}); });
export const userSearchResultValidator: TInterface<UserSearchResult> = export const userSearchResultValidator: TInterface<UserSearchResult> =
Show All 14 Lines): Promise<UserSearchResult> {
const result = { userInfos: searchResults }; const result = { userInfos: searchResults };
return validateOutput( return validateOutput(
viewer.platformDetails, viewer.platformDetails,
userSearchResultValidator, userSearchResultValidator,
result, result,
); );
} }
export { userSearchResponder }; const exactUserSearchRequestInputValidator = tShape<ExactUserSearchRequest>({
username: t.String,
});
const exactUserSearchResultValidator = tShape<ExactUserSearchResult>({
userInfo: t.maybe(globalAccountUserInfoValidator),
});
async function exactUserSearchResponder(
viewer: Viewer,
input: mixed,
): Promise<ExactUserSearchResult> {
const request = await validateInput(
viewer,
exactUserSearchRequestInputValidator,
input,
);
const searchResult = await searchForUser(request.username);
const result = { userInfo: searchResult };
return validateOutput(
viewer.platformDetails,
exactUserSearchResultValidator,
result,
);
}
export { userSearchResponder, exactUserSearchResponder };