Page MenuHomePhabricator

[keyserver] Fetch user infos together with other data
ClosedPublic

Authored by tomek on Oct 31 2023, 8:48 AM.
Tags
None
Referenced Files
F2150027: D9657.id32556.diff
Sun, Jun 30, 9:22 AM
Unknown Object (File)
Sat, Jun 15, 2:31 PM
Unknown Object (File)
May 28 2024, 6:05 PM
Unknown Object (File)
May 28 2024, 6:05 PM
Unknown Object (File)
May 28 2024, 6:05 PM
Unknown Object (File)
May 28 2024, 6:01 PM
Unknown Object (File)
May 13 2024, 8:13 AM
Unknown Object (File)
Apr 19 2024, 12:04 PM
Subscribers

Details

Summary

Instead of fetching user infos separately, we can fetch them with the rest of the infos.

Depends on D9656

Test Plan

Generate some updates, reintroduce old code, and compare new with old result using _.isEqual.
For one update, generated during sending a friend request to an unknown user, the contents don't match. That seems to expose a race condition which was already present in our code (we're fetching the users a little earlier now) - going to investigate it further.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Oct 31 2023, 9:46 AM
kamil requested changes to this revision.Nov 2 2023, 7:17 AM

For one update, generated during sending a friend request to an unknown user, the contents don't match. That seems to expose a race condition which was already present in our code (we're fetching the users a little earlier now) - going to investigate it further.

I think we first need to resolve this issue before shipping this code

This revision now requires changes to proceed.Nov 2 2023, 7:17 AM

Might be good to create (and link) a task here to investigate that issue

tomek requested review of this revision.Nov 6 2023, 4:27 AM
This revision is now accepted and ready to land.Nov 6 2023, 5:10 AM