Paths

Table of Contentst

[keyserver] Convert raw update infos in a spec
ClosedPublic
Actions

Authored by tomek on Oct 31 2023, 8:43 AM.

Details

Reviewers

kamil
inka
bartek

Commits

rCOMMa1bec7ba5a40: [keyserver] Convert raw update infos in a spec

Summary

Move the logic to a spec.

Depends on D9655

Test Plan

Generate some updates, reintroduce old code, and compare new with old result using _.isEqual

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Oct 31 2023, 8:43 AM

Herald added subscribers: will, ashoat. · View Herald TranscriptOct 31 2023, 8:43 AM

tomek added inline comments.Oct 31 2023, 8:44 AM

keyserver/src/creators/update-creator.js
508–513 ↗	(On Diff #32554)	This is going to be moved to a spec later in the stack

tomek added a child revision: D9657: [keyserver] Fetch user infos together with other data.Oct 31 2023, 8:48 AM

Harbormaster completed remote builds in B23611: Diff 32554.Oct 31 2023, 9:24 AM

tomek requested review of this revision.Oct 31 2023, 9:24 AM

kamil accepted this revision.Nov 2 2023, 7:11 AM

This revision is now accepted and ready to land.Nov 2 2023, 7:11 AM

Closed by commit rCOMMa1bec7ba5a40: [keyserver] Convert raw update infos in a spec (authored by tomek). · Explain WhyNov 6 2023, 6:59 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMa1bec7ba5a40: [keyserver] Convert raw update infos in a spec.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

update-creator.js

150 lines

lib/

shared/

updates/

bad-device-token-spec.js

8 lines

delete-account-spec.js

8 lines

delete-thread-spec.js

8 lines

join-thread-spec.js

33 lines

update-current-user-spec.js

16 lines

update-entry-spec.js

25 lines

update-spec.js

35 lines

update-thread-read-status-spec.js

9 lines

update-thread-spec.js

21 lines

update-user-spec.js

8 lines

Diff 32775

View Options

keyserver/src/creators/update-creator.js

View Options

lib/shared/updates/bad-device-token-spec.js

View Options

lib/shared/updates/delete-account-spec.js

View Options

lib/shared/updates/delete-thread-spec.js

View Options

lib/shared/updates/join-thread-spec.js

View Options

lib/shared/updates/update-current-user-spec.js

View Options

lib/shared/updates/update-entry-spec.js

View Options

lib/shared/updates/update-spec.js

View Options

lib/shared/updates/update-thread-read-status-spec.js

View Options

lib/shared/updates/update-thread-spec.js

View Options

lib/shared/updates/update-user-spec.js

[keyserver] Convert raw update infos in a specClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32775

keyserver/src/creators/update-creator.js

lib/shared/updates/bad-device-token-spec.js

lib/shared/updates/delete-account-spec.js

lib/shared/updates/delete-thread-spec.js

lib/shared/updates/join-thread-spec.js

lib/shared/updates/update-current-user-spec.js

lib/shared/updates/update-entry-spec.js

lib/shared/updates/update-spec.js

lib/shared/updates/update-thread-read-status-spec.js

lib/shared/updates/update-thread-spec.js

lib/shared/updates/update-user-spec.js

[keyserver] Convert raw update infos in a spec
ClosedPublic
Actions

Revision Contents
Changeset List