[Commtest] fix Clippy warnings and typos
ClosedPublic
Actions

Authored by kamil on Sep 28 2023, 2:29 PM.

Details

Reviewers

michal
bartek
varun
• jon

Commits

rCOMMf5edadea6168: [Commtest] fix Clippy warnings and typos

Summary

As suggested by @bartek I started using clippy linter for rust, but it's hard when it generates a lot of warnings in old code - fixing all, and some typos.

Depends on D9310

Test Plan

Run tests

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Sep 28 2023, 2:29 PM

kamil held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptSep 28 2023, 2:29 PM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

kamil added a child revision: D9312: [Commtest] add mock olm accounts, configure creating authenticated device.Sep 28 2023, 2:30 PM

Harbormaster completed remote builds in B22890: Diff 31521.Sep 28 2023, 2:46 PM

kamil published this revision for review.Sep 28 2023, 3:08 PM

bartek accepted this revision.Sep 29 2023, 7:59 AM

bartek added inline comments.

services/commtest/tests/tunnelbroker_integration_tests.rs
53	finally 😁

This revision is now accepted and ready to land.Sep 29 2023, 7:59 AM

michal accepted this revision.Sep 29 2023, 9:00 AM

Closed by commit rCOMMf5edadea6168: [Commtest] fix Clippy warnings and typos. · Explain WhyOct 11 2023, 2:39 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMf5edadea6168: [Commtest] fix Clippy warnings and typos.

Revision Contents
Changeset List

Path

Size

services/

commtest/

build.rs

2 lines

src/

identity/

device.rs

8 lines

tools.rs

16 lines

tests/

identity_tunnelbroker_tests.rs

4 lines

tunnelbroker_integration_test.rs

	tunnelbroker_integration_tests.rs
	tunnelbroker_integration_test.rs

7 lines

identity/

src/

config.rs

4 lines

shared/

tunnelbroker_messages/

src/

messages/

keys.rs

2 lines

mod.rs

2 lines

session.rs

6 lines

Diff 31521

View Options

services/commtest/build.rs

View Options

services/commtest/src/identity/device.rs

View Options

services/commtest/src/tools.rs

View Options

services/commtest/tests/identity_tunnelbroker_tests.rs

View Options

services/commtest/tests/tunnelbroker_integration_test.rs

View Options

services/commtest/tests/tunnelbroker_integration_tests.rs

View Options

services/identity/src/config.rs

View Options

shared/tunnelbroker_messages/src/messages/keys.rs

View Options

shared/tunnelbroker_messages/src/messages/mod.rs

View Options

shared/tunnelbroker_messages/src/messages/session.rs

[Commtest] fix Clippy warnings and typosClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31521

services/commtest/build.rs

services/commtest/src/identity/device.rs

services/commtest/src/tools.rs

services/commtest/tests/identity_tunnelbroker_tests.rs

services/commtest/tests/tunnelbroker_integration_test.rs

services/commtest/tests/tunnelbroker_integration_tests.rs

services/identity/src/config.rs

shared/tunnelbroker_messages/src/messages/keys.rs

shared/tunnelbroker_messages/src/messages/mod.rs

shared/tunnelbroker_messages/src/messages/session.rs

[Commtest] fix Clippy warnings and typos
ClosedPublic
Actions

Revision Contents
Changeset List