Page MenuHomePhabricator
Differential D9410

[web] introduce UserProfileModal component
ClosedPublic
Actions

Authored by ginsu on Oct 8 2023, 11:52 PM.
Tags
None
Referenced Files
F2902632: D9410.diff
Sat, Oct 5, 6:30 PM
Unknown Object (File)
Sat, Sep 14, 5:00 PM
Unknown Object (File)
Sat, Sep 14, 5:00 PM
Unknown Object (File)
Sat, Sep 14, 5:00 PM
Unknown Object (File)
Sat, Sep 14, 4:59 PM
Unknown Object (File)
Thu, Sep 12, 8:47 AM
Unknown Object (File)
Sun, Sep 8, 7:25 AM
Unknown Object (File)
Sun, Sep 8, 12:31 AM
View All 76 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMMe528772c9de5: [web] introduce UserProfileModal component
Summary

As a followup to introducing the user profile component, we should also introduce its containing component, which will be a mobile. Just like UserProfileBottomSheet this compnent will select the userInfo based on the userID and handle any containing component specific features (like onClose, etc)

https://linear.app/comm/issue/ENG-4964/introduce-user-profile-modal-component

Depends on D9409

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 8 2023, 11:52 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 8 2023, 11:52 PM
ginsu added inline comments.Oct 8 2023, 11:59 PM
web/modals/user-profile/user-profile-modal.react.js
26 ↗(On Diff #31770)

I plan to make some tweaks to improve the Modal api. I will address this and those other improvements in subsequent diffs

ginsu edited the summary of this revision. (Show Details)Oct 9 2023, 12:00 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9409: [web] introduce UserProfile component.
ginsu attached a referenced file: F804379: Screen Recording 2023-10-09 at 2.59.31 AM.mov. (Show Details)
ginsu edited the summary of this revision. (Show Details)Oct 9 2023, 12:06 AM
Harbormaster completed remote builds in B23077: Diff 31770.Oct 9 2023, 12:09 AM
ginsu requested review of this revision.Oct 9 2023, 12:09 AM
ginsu added a child revision: D9411: [web] introduce copy username functionality to user profiles.Oct 9 2023, 12:16 AM
atul accepted this revision.Oct 9 2023, 1:52 PM
atul added inline comments.
web/modals/user-profile/user-profile-modal.react.js
24–29 ↗(On Diff #31770)

Can we wrap in useMemo

This revision is now accepted and ready to land.Oct 9 2023, 1:52 PM
ginsu updated this revision to Diff 32048.Oct 16 2023, 9:55 PM

address @atul's comments + rebase before landing

Harbormaster completed remote builds in B23271: Diff 32048.Oct 16 2023, 10:12 PM
Closed by commit rCOMMe528772c9de5: [web] introduce UserProfileModal component (authored by ginsu). · Explain WhyOct 16 2023, 10:58 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMe528772c9de5: [web] introduce UserProfileModal component.

Revision Contents
Changeset List

PathSize
web/
modals/
user-profile/
37 lines

Diff 32048

View Options

web/modals/user-profile/user-profile-modal.react.js

Loading...