Page MenuHomePhabricator
Differential D9431

[web] introduce UserProfileActionButtons
ClosedPublic
Actions

Authored by ginsu on Oct 9 2023, 10:05 AM.
Tags
None
Referenced Files
F3521273: D9431.id32066.diff
Mon, Dec 23, 2:47 AM
F3521272: D9431.id32051.diff
Mon, Dec 23, 2:47 AM
F3521271: D9431.id31818.diff
Mon, Dec 23, 2:47 AM
F3519615: D9431.id.diff
Sun, Dec 22, 10:43 PM
Unknown Object (File)
Mon, Dec 9, 6:34 PM
Unknown Object (File)
Nov 20 2024, 3:12 AM
Unknown Object (File)
Nov 16 2024, 11:41 PM
Unknown Object (File)
Nov 16 2024, 2:33 AM
View All 76 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMM4788563f474c: [web] introduce UserProfileActionButtons
Summary

Based on the designs, the action buttons for the user profiles on web are going to be rendered pretty differently based on what the user relationship status is. In an effort to not oversaturate UserProfile, I am going to create this separate component that UserProfiles can call and render

For context:

Screenshot 2023-10-09 at 1.07.25 PM.png (952×1 px, 198 KB)

Screenshot 2023-10-09 at 1.07.36 PM.png (626×832 px, 115 KB)

Screenshot 2023-10-09 at 1.07.30 PM.png (524×922 px, 105 KB)

Part of https://linear.app/comm/issue/ENG-4967/introduceport-userprofilerelationshipbutton

Depends on D9412

Test Plan

flow and confirmed that there were no regressions with user profiles on web.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 9 2023, 10:05 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 9 2023, 10:05 AM
ginsu edited the summary of this revision. (Show Details)Oct 9 2023, 10:09 AM
ginsu added reviewers: atul, inka.
ginsu attached a referenced file: F805724: Screenshot 2023-10-09 at 1.07.25 PM.png. (Show Details)
ginsu attached a referenced file: F805722: Screenshot 2023-10-09 at 1.07.36 PM.png. (Show Details)
ginsu attached a referenced file: F805721: Screenshot 2023-10-09 at 1.07.30 PM.png. (Show Details)
ginsu edited the summary of this revision. (Show Details)Oct 9 2023, 10:23 AM
ginsu added a parent revision: D9412: [web] introduce UserProfileMessageButton.
Harbormaster completed remote builds in B23112: Diff 31818.Oct 9 2023, 10:23 AM
ginsu requested review of this revision.Oct 9 2023, 10:23 AM
atul added inline comments.Oct 9 2023, 2:07 PM
web/modals/user-profile/user-profile-action-buttons.react.js
18–20 ↗(On Diff #31818)

Doesn't hurt to memoize (we got a SVG inside)

atul accepted this revision.Oct 9 2023, 2:07 PM
This revision is now accepted and ready to land.Oct 9 2023, 2:07 PM
ginsu added a child revision: D9446: [web] update RelationshipPromptButton to be more reusable.Oct 10 2023, 10:54 AM
ginsu updated this revision to Diff 32051.Oct 16 2023, 10:09 PM

address @atul's comments + rebase before landing

Harbormaster completed remote builds in B23274: Diff 32051.Oct 16 2023, 10:27 PM
Closed by commit rCOMM4788563f474c: [web] introduce UserProfileActionButtons (authored by ginsu). · Explain WhyOct 16 2023, 10:58 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM4788563f474c: [web] introduce UserProfileActionButtons.

Revision Contents
Changeset List

PathSize
web/
modals/
user-profile/
29 lines
10 lines

Diff 32051

View Options

web/modals/user-profile/user-profile-action-buttons.react.js

Loading...
View Options

web/modals/user-profile/user-profile.react.js

Loading...