Page MenuHomePhabricator
Differential D9446

[web] update RelationshipPromptButton to be more reusable
ClosedPublic
Actions

Authored by ginsu on Oct 10 2023, 10:53 AM.
Tags
None
Referenced Files
F3521276: D9446.id32065.diff
Mon, Dec 23, 2:47 AM
F3521275: D9446.id32052.diff
Mon, Dec 23, 2:47 AM
F3521274: D9446.id31881.diff
Mon, Dec 23, 2:47 AM
F3519618: D9446.id.diff
Sun, Dec 22, 10:43 PM
Unknown Object (File)
Nov 21 2024, 6:27 PM
Unknown Object (File)
Nov 18 2024, 6:23 PM
Unknown Object (File)
Nov 14 2024, 7:27 AM
Unknown Object (File)
Nov 14 2024, 7:27 AM
View All 79 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMMa995af541e99: [web] update RelationshipPromptButton to be more reusable
Summary

I want to use RelationshipPromptButton in user profiles. Right now there are some styles that are making it difficult to do that. In this diff I moved/changed some of the styles around + snuck in a quick memoization improvement to this component

Depends on D9431

Test Plan

Confirmed that RelationshipPromptButton looked and behaved the same

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 10 2023, 10:53 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 10 2023, 10:53 AM
ginsu added reviewers: atul, inka.Oct 10 2023, 10:54 AM
ginsu edited the summary of this revision. (Show Details)
ginsu added a parent revision: D9431: [web] introduce UserProfileActionButtons.
ginsu added inline comments.
web/chat/relationship-prompt/relationship-prompt-button.js
23 ↗(On Diff #31881)

Added memoization here since we are rendering an svg here

Harbormaster completed remote builds in B23153: Diff 31881.Oct 10 2023, 11:13 AM
ginsu requested review of this revision.Oct 10 2023, 11:13 AM
ginsu added a child revision: D9447: [web] implement RelationshipPromptButtons into user profiles.Oct 10 2023, 12:39 PM
atul accepted this revision.Oct 16 2023, 8:54 AM
atul added inline comments.
web/chat/relationship-prompt/relationship-prompt-button.js
23 ↗(On Diff #31881)

Thanks for doing that

This revision is now accepted and ready to land.Oct 16 2023, 8:54 AM
ginsu updated this revision to Diff 32052.Oct 16 2023, 10:13 PM

rebase before landing

Harbormaster completed remote builds in B23275: Diff 32052.Oct 16 2023, 10:30 PM
Closed by commit rCOMMa995af541e99: [web] update RelationshipPromptButton to be more reusable (authored by ginsu). · Explain WhyOct 16 2023, 10:58 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMa995af541e99: [web] update RelationshipPromptButton to be more reusable.

Revision Contents
Changeset List

PathSize
web/
chat/
relationship-prompt/
31 lines
8 lines

Diff 32065

View Options

web/chat/relationship-prompt/relationship-prompt-button.js

Loading...
View Options

web/chat/relationship-prompt/relationship-prompt.css

Loading...