[web] introduce user-profile as a menu variant
ClosedPublic
Actions

Authored by ginsu on Oct 12 2023, 1:00 AM.

Details

Reviewers

atul
inka

Commits

rCOMM532584f5e9dd: [web] introduce user-profile as a menu variant

Summary

The first step to introducing the user profile menu is that we need to create a user-profile className variant in Menu. This className handles things like the menu background color, the placement, and the color of the content

Screenshot of designs:

Screenshot 2023-10-12 at 4.03.39 AM.png (702×1 px, 140 KB)

Part of https://linear.app/comm/issue/ENG-5225/introduce-userprofilemenu

Depends on D9455

Test Plan

Please see the screenshot below to see what the container of the menu looks like

Screenshot 2023-10-12 at 4.05.00 AM.png (1×3 px, 942 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 12 2023, 1:00 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 12 2023, 1:01 AM

ginsu edited the summary of this revision. (Show Details)Oct 12 2023, 1:05 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9455: [web] introduce secondaryHeaderButton prop to Modal component.

ginsu attached a referenced file: F810025: Screenshot 2023-10-12 at 4.05.00 AM.png. (Show Details)

Harbormaster completed remote builds in B23201: Diff 31953.Oct 12 2023, 1:18 AM

ginsu requested review of this revision.Oct 12 2023, 1:18 AM

ginsu added a child revision: D9457: [web] introduce UserProfileMenu.Oct 12 2023, 1:29 AM

atul accepted this revision.Oct 16 2023, 9:34 AM

atul added a subscriber: • ted.

atul added inline comments.

web/components/menu.react.js
9–14 ↗	(On Diff #31953)	We should consolidate + tidy up `Menu` component as part of design system so we aren't constantly creating one-off variants. CC @ashoat, @ted: not sure how/when to prioritize, but just to keep on your radar

This revision is now accepted and ready to land.Oct 16 2023, 9:34 AM

ginsu added inline comments.Oct 16 2023, 10:32 PM

web/components/menu.react.js
9–14 ↗	(On Diff #31953)	created a linear task to track + unblock landing: https://linear.app/comm/issue/ENG-5273/make-generic-variants-for-our-menu-component