[native] introduce barebones keyserver selection bottom sheet to root navigator
ClosedPublic
Actions

Authored by ginsu on Nov 6 2023, 7:11 AM.

Details

Reviewers

rohan
inka
michal

Commits

rCOMM3f865976197b: [native] introduce barebones keyserver selection bottom sheet to root navigator

Summary

This diff introduces the barebones keyserver selection bottom sheet component as well as all the necessary logic needed to add this to the root navigator to eventually route to it. Subsquent diffs will handle fully introducing the UI and all the other functionality needed for this bottom sheet

Linear task: https://linear.app/comm/issue/ENG-5472/add-keyserverselectionbottomsheet-to-the-root-navigator

Depends on D9725

Test Plan

Confirmed that I was able to get to this barebones bottomsheet when I pressed on a keyserver selection list item

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Nov 6 2023, 7:11 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 6 2023, 7:11 AM

ginsu edited the summary of this revision. (Show Details)Nov 6 2023, 7:12 AM

ginsu added reviewers: rohan, inka, michal.

ginsu added a parent revision: D9725: [native] factor keyserver list item into its own component.

Harbormaster completed remote builds in B23794: Diff 32782.Nov 6 2023, 7:39 AM

ginsu requested review of this revision.Nov 6 2023, 7:39 AM

ginsu planned changes to this revision.Nov 6 2023, 2:42 PM

Ran into a bug later in the stack with reading some of the route params, and thought the issue was with this diff, but it was actually with something else

ginsu added a child revision: D9753: [native] introduce status indicator component.Nov 7 2023, 11:28 AM

inka accepted this revision.Nov 9 2023, 2:16 AM

This revision is now accepted and ready to land.Nov 9 2023, 2:16 AM

inka added inline comments.Nov 9 2023, 2:52 AM

native/profile/keyserver-selection-bottom-sheet.react.js
12	What will this be used for? Where will it be fetched from? Should we include this in `keyserverInfo`?

ginsu added inline comments.Nov 9 2023, 8:44 AM

native/profile/keyserver-selection-bottom-sheet.react.js
12	This will be used to display the username of the keyserver admin: In the screenshot above, ashoat and I are the values that got passed in for `keyserverAdminUsername`. In D9641, I introduced a selector that would get the `keyserverAdminUsername` for each keyserver info