[web] Change `ConfirmLeaveThreadModal` size to `fit-content`
ClosedPublic
Actions

Authored by • jacek on Apr 25 2022, 10:01 AM.

Details

Reviewers

tomek
• benschac
atul

Commits

rCOMM793626f9a376: [web] Change `ConfirmLeaveThreadModal` size to `fit-content`

Summary

After Modal redesign, the modal size must be set to fit-content to display it with correct size.

Before:

Screenshot_Google Chrome_2022-04-25_190226.png (404×646 px, 40 KB)

After:

Screenshot_Google Chrome_2022-04-25_190200.png (354×750 px, 37 KB)

Test Plan

Try to leave the thread in web app - the modal size should now be correct

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Apr 25 2022, 10:01 AM

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptApr 25 2022, 10:01 AM

• jacek edited the summary of this revision. (Show Details)Apr 25 2022, 10:04 AM

• jacek added reviewers: tomek, • benschac, atul.

Harbormaster completed remote builds in B8515: Diff 11874.Apr 25 2022, 10:08 AM

• jacek requested review of this revision.Apr 25 2022, 10:08 AM

Are there any other modals that need this update? Adding @atul as a blocking reviewer to make sure he sees this as he's been cleaning up some modals recently

• jacek added a parent revision: D3669: [web] Redesign `Modal` to match Figma.Apr 25 2022, 10:11 AM

tomek accepted this revision.Apr 26 2022, 4:24 AM

In D3836#106509, @ashoat wrote:

Are there any other modals that need this update? Adding @atul as a blocking reviewer to make sure he sees this as he's been cleaning up some modals recently

I tried to test all existing modals after rebasing modals redesign, and found only this (newly introduced) one. If I haven't missed anything, all others can remain unchanged

Looks good, I wonder if longer term the "right place" to put fit-content is somewhere in the CSS?

This revision is now accepted and ready to land.Apr 26 2022, 7:54 AM

rebase

Harbormaster completed remote builds in B8559: Diff 11928.Apr 26 2022, 8:59 AM

revert accidental change after rebase

Harbormaster completed remote builds in B8561: Diff 11930.Apr 26 2022, 9:07 AM

Closed by commit rCOMM793626f9a376: [web] Change `ConfirmLeaveThreadModal` size to `fit-content` (authored by • jacek). · Explain WhyApr 26 2022, 9:09 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM793626f9a376: [web] Change `ConfirmLeaveThreadModal` size to `fit-content`.