Details

Reviewers

tomek
ashoat

Commits

rCOMMf74253438fcc: [services] Lib - Move server base reactors

Summary

Depends on D3911

Moving server base reactors from both blob/backup to the mutual "lib" space.

Test Plan

No real changes are applied, just moving stuff around, so services should still build and that's the test plan

cd services

yarn run-blob-service
yarn run-backup-service

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.May 4 2022, 6:22 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 4 2022, 6:22 AM

• karol edited the summary of this revision. (Show Details)May 4 2022, 6:51 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D3911: [services] Lib - Move reactor utility.

• karol added a child revision: D3913: [services] Lib - Move client base reactors.

Harbormaster completed remote builds in B8770: Diff 12217.May 4 2022, 7:31 AM

• karol requested review of this revision.May 4 2022, 7:31 AM

I don't like the lib_src folder and I'd like to move away from having a different directory structure inside vs. outside Docker if possible, see feedback in D3909

This revision now requires changes to proceed.May 4 2022, 11:06 AM

update

Harbormaster failed remote builds in B8890: Diff 12394!May 9 2022, 2:09 AM

• karol planned changes to this revision.May 9 2022, 2:23 AM

fix ci

Harbormaster completed remote builds in B8902: Diff 12406.May 9 2022, 2:44 AM

rebased

rebase

Harbormaster failed remote builds in B8931: Diff 12440!May 9 2022, 7:34 AM

Harbormaster completed remote builds in B8931: Diff 12440.May 9 2022, 7:54 AM

ashoat accepted this revision.May 9 2022, 9:34 AM

This revision is now accepted and ready to land.May 9 2022, 9:34 AM

rebase

Harbormaster completed remote builds in B8955: Diff 12465.May 10 2022, 1:13 AM

Closed by commit rCOMMf74253438fcc: [services] Lib - Move server base reactors (authored by • karol). · Explain WhyMay 10 2022, 6:39 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMf74253438fcc: [services] Lib - Move server base reactors.

[services] Lib - Move server base reactors
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 12217

services/backup/CMakeLists.txt

services/backup/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

services/backup/src/Reactors/server/base-reactors/ServerReadReactorBase.h

services/backup/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

services/blob/CMakeLists.txt

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

services/lib/lib_src/server-base-reactors/ServerBidiReactorBase.h

services/lib/lib_src/server-base-reactors/ServerReadReactorBase.h

services/lib/lib_src/server-base-reactors/ServerWriteReactorBase.h

[services] Lib - Move server base reactorsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12217

services/backup/CMakeLists.txt

services/backup/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

services/backup/src/Reactors/server/base-reactors/ServerReadReactorBase.h

services/backup/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

services/blob/CMakeLists.txt

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

services/lib/lib_src/server-base-reactors/ServerBidiReactorBase.h

services/lib/lib_src/server-base-reactors/ServerReadReactorBase.h

services/lib/lib_src/server-base-reactors/ServerWriteReactorBase.h

[services] Lib - Move server base reactors
ClosedPublic
Actions

Revision Contents
Changeset List