Depends on D3910
Moving reactor utility from both blob/backup to the mutual "lib" space.
Differential D3911 Authored by • karol on May 4 2022, 1:21 PM.
Details
Summary Depends on D3910 Moving reactor utility from both blob/backup to the mutual "lib" space. Test Plan No real changes are applied, just moving stuff around, so services should still build and that's the test plan cd services yarn run-blob-service yarn run-backup-service
Diff Detail
Event TimelineHerald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 4 2022, 1:21 PM2022-05-04 13:21:45 (UTC+0) • karol edited the summary of this revision. (Show Details)May 4 2022, 1:51 PM2022-05-04 13:51:21 (UTC+0) Harbormaster completed remote builds in B8769: Diff 12215.May 4 2022, 2:26 PM2022-05-04 14:26:44 (UTC+0) Comment Actions I don't like the lib_src folder and I'd like to move away from having a different directory structure inside vs. outside Docker if possible, see feedback in D3909 This revision now requires changes to proceed.May 4 2022, 6:06 PM2022-05-04 18:06:05 (UTC+0) Harbormaster failed remote builds in B8889: Diff 12393!May 9 2022, 9:08 AM2022-05-09 09:08:32 (UTC+0) Harbormaster completed remote builds in B8901: Diff 12405.May 9 2022, 9:44 AM2022-05-09 09:44:49 (UTC+0) This revision is now accepted and ready to land.May 9 2022, 12:54 PM2022-05-09 12:54:41 (UTC+0) Harbormaster completed remote builds in B8954: Diff 12464.May 10 2022, 8:08 AM2022-05-10 08:08:46 (UTC+0) Closed by commit rCOMMca522f382161: [services] Lib - Move reactor utility. · Explain WhyMay 10 2022, 1:39 PM2022-05-10 13:39:45 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 12405 |