Page MenuHomePhabricator
Differential D3970

[services] Add hasEnvFlag
ClosedPublic
Actions

Authored by • karol on May 9 2022, 8:24 AM.
Tags
None
Referenced Files
F2149400: D3970.id12516.diff
Sun, Jun 30, 7:54 AM
F2149399: D3970.id12444.diff
Sun, Jun 30, 7:54 AM
F2149398: D3970.id12443.diff
Sun, Jun 30, 7:54 AM
F2149381: D3970.id.diff
Sun, Jun 30, 7:54 AM
F2149360: D3970.diff
Sun, Jun 30, 7:50 AM
F2142284: D3970.diff
Sat, Jun 29, 1:52 PM
Unknown Object (File)
Tue, Jun 18, 9:16 AM
Unknown Object (File)
Mon, Jun 17, 2:00 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
Commits
rCOMM96e140e572c4: [services] Add hasEnvFlag
Summary

Depends on D3956

https://linear.app/comm/issue/ENG-1104/consider-creating-hasenvflag-function

Test Plan
cd services
yarn test-backup-service-dev-mode
yarn test-blob-service-dev-mode

and

cd services
git grep "std::getenv"

Should only print two results from lib/src/GlobalTools.cpp (also something from the tunnelbroker but it isn't relevant)

Diff Detail

Repository
rCOMM Comm
Branch
services-lib
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.May 9 2022, 8:24 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 9 2022, 8:24 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 9 2022, 8:26 AM
Harbormaster failed remote builds in B8934: Diff 12443!
• karol edited the summary of this revision. (Show Details)May 9 2022, 8:30 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3956: [services] Lib - Add Base Database Manager.
• karol updated this revision to Diff 12444.May 9 2022, 8:33 AM
• karol edited the summary of this revision. (Show Details)

fix build

Harbormaster returned this revision to the author for changes because remote builds failed.May 9 2022, 12:12 PM
Harbormaster failed remote builds in B8935: Diff 12444!
• karol requested review of this revision.May 10 2022, 12:57 AM

Only android failed, so I'm force-pushing it.

tomek accepted this revision.May 10 2022, 1:08 AM
This revision is now accepted and ready to land.May 10 2022, 1:08 AM
tomek added a comment.May 10 2022, 1:08 AM

The test plan here should contain some info about searching our codebase and checking if all the usages were replaced.

• karol edited the test plan for this revision. (Show Details)May 10 2022, 1:27 AM

added

• karol added a child revision: D3985: [services] Blob - Delete dangling build_server.sh script.May 10 2022, 2:55 AM
This revision was landed with ongoing or failed builds.May 10 2022, 7:31 AM
Closed by commit rCOMM96e140e572c4: [services] Add hasEnvFlag (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM96e140e572c4: [services] Add hasEnvFlag.

Revision Contents
Changeset List

PathSize
services/
lib/
src/
2 lines
15 lines

Diff 12444

View Options

services/lib/src/GlobalTools.h

Loading...
View Options

services/lib/src/GlobalTools.cpp

Loading...