Page MenuHomePhabricator
Differential D3943

[services] Lib - Move dynamo DB tools
ClosedPublic
Actions

Authored by • karol on May 6 2022, 6:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 5:19 PM
Unknown Object (File)
Sun, Nov 10, 5:19 PM
Unknown Object (File)
Sun, Nov 10, 5:19 PM
Unknown Object (File)
Sun, Nov 10, 5:19 PM
Unknown Object (File)
Sun, Nov 10, 5:18 PM
Unknown Object (File)
Sun, Nov 10, 5:18 PM
Unknown Object (File)
Fri, Nov 8, 3:46 AM
Unknown Object (File)
Tue, Nov 5, 3:46 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
ashoat
Commits
rCOMMe6ccec347979: [services] Lib - Move dynamo DB tools
Summary

Depends on D3942

Moving the aws tools for dynamo DB to the "lib" space, so they can be used by all services that need the database access on AWS.

Test Plan
cd services
yarn run-local-cloud
yarn test-backup-service-dev-mode
yarn test-blob-service-dev-mode

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.May 6 2022, 6:29 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 6 2022, 6:29 AM
Harbormaster completed remote builds in B8854: Diff 12350.May 6 2022, 6:34 AM
• karol requested review of this revision.May 6 2022, 6:34 AM
• karol edited the summary of this revision. (Show Details)May 6 2022, 6:34 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3942: [services] Backup/Blob - Split aws tools into two tool sets.
• karol added a child revision: D3950: [services] Lib - Introduce Global Constants.May 6 2022, 7:49 AM
• karol planned changes to this revision.May 9 2022, 2:07 AM
• karol updated this revision to Diff 12397.May 9 2022, 2:09 AM

update

Harbormaster failed remote builds in B8893: Diff 12397!May 9 2022, 2:12 AM
• karol planned changes to this revision.May 9 2022, 2:23 AM
• karol updated this revision to Diff 12409.May 9 2022, 2:34 AM

fix ci

Harbormaster completed remote builds in B8905: Diff 12409.May 9 2022, 2:53 AM
ashoat requested changes to this revision.May 9 2022, 9:20 AM
ashoat added inline comments.
services/blob/CMakeLists.txt
29 ↗(On Diff #12409)

Should lib_src be removed here? Assuming based on your update comments in D3909 where you removed it

This revision now requires changes to proceed.May 9 2022, 9:20 AM
• karol added inline comments.May 10 2022, 12:48 AM
services/blob/CMakeLists.txt
29 ↗(On Diff #12409)

yes, I missed this, thx

• karol updated this revision to Diff 12461.May 10 2022, 12:49 AM

remove cmakelists entries with lib_src

Harbormaster completed remote builds in B8951: Diff 12461.May 10 2022, 12:56 AM
ashoat accepted this revision.May 10 2022, 5:46 AM
This revision is now accepted and ready to land.May 10 2022, 5:46 AM
Closed by commit rCOMMe6ccec347979: [services] Lib - Move dynamo DB tools (authored by • karol). · Explain WhyMay 10 2022, 6:39 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMe6ccec347979: [services] Lib - Move dynamo DB tools.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
blob/
2 lines
src/
lib/
src/
backup/
src/
16 lines
18 lines

Diff 12461

View Options

services/backup/src/DynamoDBTools.h

Loading...
View Options

services/backup/src/DynamoDBTools.cpp

Loading...
View Options

services/blob/CMakeLists.txt

Loading...
View Options

services/blob/src/DynamoDBTools.h

Loading...
View Options

services/blob/src/DynamoDBTools.cpp

Loading...
View Options

services/lib/src/DynamoDBTools.h

Loading...
View Options

services/lib/src/DynamoDBTools.cpp

Loading...