Page MenuHomePhabricator
Differential D3987

[services] Lib - Tunnelbroker - Use cmake components
ClosedPublic
Actions

Authored by • karol on May 10 2022, 4:26 AM.
Tags
None
Referenced Files
F3266169: D3987.id12568.diff
Sat, Nov 16, 1:42 AM
F3262781: D3987.diff
Fri, Nov 15, 11:49 PM
F3247656: D3987.diff
Fri, Nov 15, 6:10 AM
Unknown Object (File)
Thu, Nov 7, 3:14 AM
Unknown Object (File)
Wed, Nov 6, 2:27 AM
Unknown Object (File)
Tue, Nov 5, 3:14 PM
Unknown Object (File)
Oct 13 2024, 2:20 PM
Unknown Object (File)
Oct 13 2024, 2:20 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
• max
Commits
rCOMMac99b4be449d: [services] Lib - Tunnelbroker - Use cmake components
Summary

Depends on D3985

Just removing cmake components from the tunnelbroker directory and linking the ones from the "lib" directory

Test Plan

You should be able to build tunnelbroker properly

cd services
yarn run-tunnelbroker-service

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.May 10 2022, 4:26 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 10 2022, 4:26 AM
Harbormaster completed remote builds in B8979: Diff 12489.May 10 2022, 4:31 AM
• karol requested review of this revision.May 10 2022, 4:31 AM
• karol edited the summary of this revision. (Show Details)May 10 2022, 4:39 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max.
• karol added a parent revision: D3985: [services] Blob - Delete dangling build_server.sh script.
• karol added a child revision: D3988: [services] Lib - Tunnelbroker - Use scripts.
• karol added 1 blocking reviewer(s): • max.May 10 2022, 6:49 AM
• max accepted this revision.May 10 2022, 10:51 PM

Looks ok for me, but when we will use nix or vcpkg approach we will use only a simple find_package(,,,) in the CMakeLists.txt and don't use these includes any more.

This revision is now accepted and ready to land.May 10 2022, 10:51 PM
Closed by commit rCOMMac99b4be449d: [services] Lib - Tunnelbroker - Use cmake components (authored by • karol). · Explain WhyMay 12 2022, 1:56 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMac99b4be449d: [services] Lib - Tunnelbroker - Use cmake components.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
1 line
cmake-components/

Diff 12489

View Options

services/tunnelbroker/Dockerfile

Loading...
View Options

services/tunnelbroker/cmake-components/folly.cmake

Loading...
View Options

services/tunnelbroker/cmake-components/grpc.cmake

Loading...