Paths

Table of Contentst

Differential D3988

[services] Lib - Tunnelbroker - Use scripts
ClosedPublic
Actions

Authored by • karol on May 10 2022, 4:26 AM.

Tags

None

Referenced Files

	F3536222: D3988.id12490.diff
	Wed, Dec 25, 5:49 PM

	F3531133: D3988.diff
	Wed, Dec 25, 6:11 AM

	Unknown Object (File)
	Thu, Dec 19, 11:55 PM

	Unknown Object (File)
	Thu, Dec 19, 11:55 PM

	Unknown Object (File)
	Thu, Dec 19, 11:55 PM

	Unknown Object (File)
	Thu, Dec 19, 11:50 PM

	Unknown Object (File)
	Sat, Nov 30, 2:36 AM

	Unknown Object (File)
	Nov 14 2024, 9:09 AM

Subscribers

Details

Reviewers

tomek
• max

Commits

rCOMM8b584c4c981e: [services] Lib - Tunnelbroker - Use scripts

Summary

Depends on D3987

Removing as many scripts as possible from the tunnelbroker directory and using the ones from the "lib" directory instead.

Test Plan

You should be able to build tunnelbroker properly

cd services
yarn run-tunnelbroker-service

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.May 10 2022, 4:26 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 10 2022, 4:26 AM

Harbormaster completed remote builds in B8980: Diff 12490.May 10 2022, 4:36 AM

• karol requested review of this revision.May 10 2022, 4:36 AM

• karol edited the summary of this revision. (Show Details)May 10 2022, 4:40 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

• karol added a parent revision: D3987: [services] Lib - Tunnelbroker - Use cmake components.

• karol added a child revision: D3989: [services] Lib - Tunnelbroker - Use sources.May 10 2022, 4:42 AM

• karol added 1 blocking reviewer(s): • max.May 10 2022, 6:49 AM

That makes sense to me to make the directory structure more clear. Thanks @karol-bisztyga !

• max accepted this revision.May 10 2022, 10:53 PM

This revision is now accepted and ready to land.May 10 2022, 10:53 PM

Closed by commit rCOMM8b584c4c981e: [services] Lib - Tunnelbroker - Use scripts (authored by • karol). · Explain WhyMay 12 2022, 1:57 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM8b584c4c981e: [services] Lib - Tunnelbroker - Use scripts.

ashoat added inline comments.May 12 2022, 11:24 AM

services/tunnelbroker/Dockerfile
31 ↗	(On Diff #12569)	This seems like a mistake – it is running `run_service.sh` in both conditions. Either we should get rid of the conditional, or (most likely) it is supposed to call `run_tests.sh` in the other case PS – we prefer `[[ ]]` to `[ ]`, would be great to update this

• karol mentioned this in D4052: [services] Tunnelbroker - Fix scripts in Dockerfiles.May 16 2022, 2:58 AM

• karol added inline comments.May 16 2022, 3:03 AM

services/tunnelbroker/Dockerfile
31 ↗	(On Diff #12569)	Nice catch. D4052 `[[ ]]` doesn't work

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

7 lines

docker/

build_server.sh

install_folly.sh

Diff 12490

services/tunnelbroker/Dockerfile

Loading...

services/tunnelbroker/docker/build_server.sh

Loading...

services/tunnelbroker/docker/install_folly.sh

Loading...

services/tunnelbroker/docker/run_server.sh

Loading...

services/tunnelbroker/docker/run_tests.sh

Loading...