Page MenuHomePhabricator
Differential D3911

[services] Lib - Move reactor utility
ClosedPublic
Actions

Authored by • karol on May 4 2022, 6:21 AM.
Tags
None
Referenced Files
F3264201: D3911.id12393.diff
Sat, Nov 16, 12:28 AM
F3262007: D3911.id12215.diff
Fri, Nov 15, 11:32 PM
Unknown Object (File)
Tue, Nov 5, 3:55 PM
Unknown Object (File)
Wed, Oct 23, 3:59 AM
Unknown Object (File)
Oct 16 2024, 2:27 AM
Unknown Object (File)
Oct 13 2024, 2:43 PM
Unknown Object (File)
Oct 13 2024, 2:43 PM
Unknown Object (File)
Oct 13 2024, 2:43 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
ashoat
Commits
rCOMMca522f382161: [services] Lib - Move reactor utility
Summary

Depends on D3910

Moving reactor utility from both blob/backup to the mutual "lib" space.

Test Plan

No real changes are applied, just moving stuff around, so services should still build and that's the test plan

cd services

yarn run-blob-service
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.May 4 2022, 6:21 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 4 2022, 6:21 AM
• karol edited the summary of this revision. (Show Details)May 4 2022, 6:51 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3910: [services] Lib - Move base reactor.
• karol added a child revision: D3912: [services] Lib - Move server base reactors.
Harbormaster completed remote builds in B8769: Diff 12215.May 4 2022, 7:26 AM
• karol requested review of this revision.May 4 2022, 7:26 AM
ashoat requested changes to this revision.May 4 2022, 11:06 AM

I don't like the lib_src folder and I'd like to move away from having a different directory structure inside vs. outside Docker if possible, see feedback in D3909

This revision now requires changes to proceed.May 4 2022, 11:06 AM
• karol updated this revision to Diff 12393.May 9 2022, 2:06 AM
• karol edited the summary of this revision. (Show Details)

update

Harbormaster failed remote builds in B8889: Diff 12393!May 9 2022, 2:08 AM
• karol planned changes to this revision.May 9 2022, 2:23 AM
• karol updated this revision to Diff 12405.May 9 2022, 2:32 AM

fix ci

Harbormaster completed remote builds in B8901: Diff 12405.May 9 2022, 2:44 AM
ashoat accepted this revision.May 9 2022, 5:54 AM

This directory structure looks good to me

This revision is now accepted and ready to land.May 9 2022, 5:54 AM
• karol updated this revision to Diff 12464.May 10 2022, 12:54 AM

rebase

Harbormaster completed remote builds in B8954: Diff 12464.May 10 2022, 1:08 AM
Closed by commit rCOMMca522f382161: [services] Lib - Move reactor utility (authored by • karol). · Explain WhyMay 10 2022, 6:39 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMca522f382161: [services] Lib - Move reactor utility.

Revision Contents
Changeset List

PathSize
services/
lib/
src/
39 lines

Diff 12506

View Options

services/lib/src/ReactorUtility.h

Loading...