Paths

Table of Contentst

-
native/chat/
-
chat/
-
composed-message.react.js

[native] [refactor] [ENG-530] refactor container margin bottom if statement
ClosedPublic
Actions

Authored by • benschac on May 10 2022, 10:36 AM.

Details

Reviewers

atul
tomek
• jacek
• derek

Commits

rCOMM206d81a9a618: [native] [refactor] [ENG-530] refactor container margin bottom if statement

Summary

use if else syntax the that's used project wide.

before:

after:

Test Plan

Cluster margin should work as expected in chat view.

Diff Detail

Repository

rCOMM Comm

Branch

inline-sidebar-web-and-native-ENG-530

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.May 10 2022, 10:36 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 10 2022, 10:36 AM

• benschac added a parent revision: D3996: [native] [refactor] [ENG-530] organize constants and utils in chat directory.May 10 2022, 10:36 AM

• benschac edited the summary of this revision. (Show Details)

• benschac added inline comments.May 10 2022, 10:39 AM

native/chat/composed-message.react.js
78 ↗	(On Diff #12525)	Additionally, I need to add another condition in here and using an if else is easier to read here.

Harbormaster completed remote builds in B8991: Diff 12525.May 10 2022, 10:41 AM

• benschac requested review of this revision.May 10 2022, 10:41 AM

[native] [fix] [ENG-1123] update chat bubble design

Harbormaster completed remote builds in B8992: Diff 12526.May 10 2022, 11:46 AM

• benschac added a child revision: D3998: [native] [fix] [ENG-1123] update message chat bubble design to match design (more padding and line height).May 10 2022, 11:56 AM

This is not only a refactor, but it also changes the logic. In the previous version, when item.endsCluster then marginBottom: 5 + clusterEndHeight, but now marginBottom: clusterEndHeight. Is that intentional?

This revision now requires changes to proceed.May 11 2022, 5:46 AM

fix logic

In D3997#112145, @palys-swm wrote:

This is not only a refactor, but it also changes the logic. In the previous version, when item.endsCluster then marginBottom: 5 + clusterEndHeight, but now marginBottom: clusterEndHeight. Is that intentional?

You're right, thanks for catching this.

Harbormaster failed remote builds in B8997: Diff 12535!May 11 2022, 6:06 AM

tomek accepted this revision.May 11 2022, 6:08 AM

This revision is now accepted and ready to land.May 11 2022, 6:08 AM

Harbormaster completed remote builds in B8997: Diff 12535.May 11 2022, 9:25 AM

Closed by commit rCOMM206d81a9a618: [native] [refactor] [ENG-530] refactor container margin bottom if statement (authored by • benschac). · Explain WhyMay 11 2022, 11:42 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM206d81a9a618: [native] [refactor] [ENG-530] refactor container margin bottom if statement.

Revision Contents
Changeset List

Path

Size

native/

chat/

composed-message.react.js

8 lines

Diff 12526

View Options

native/chat/composed-message.react.js

	Show All 29 Lines
	} from '../types/redux-types.js';			} from '../types/redux-types.js';
	import type {			import type {
	ClientSessionChange,			ClientSessionChange,
	PreRequestUserState,			PreRequestUserState,
	} from '../types/session-types.js';			} from '../types/session-types.js';
	import type { ConnectionStatus } from '../types/socket-types.js';			import type { ConnectionStatus } from '../types/socket-types.js';
	import type { CurrentUserInfo } from '../types/user-types.js';			import type { CurrentUserInfo } from '../types/user-types.js';

				function extractKeyserverIDFromID(id: string): ?string {
				return id.split('\|')[0];
				}

	let nextPromiseIndex = 0;			let nextPromiseIndex = 0;

	export type ActionTypes<			export type ActionTypes<
	STARTED_ACTION_TYPE: string,			STARTED_ACTION_TYPE: string,
	SUCCESS_ACTION_TYPE: string,			SUCCESS_ACTION_TYPE: string,
	FAILED_ACTION_TYPE: string,			FAILED_ACTION_TYPE: string,
	> = {			> = {
	started: STARTED_ACTION_TYPE,			started: STARTED_ACTION_TYPE,
	▲ Show 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
	export {			export {
	useDispatchActionPromise,			useDispatchActionPromise,
	setNewSessionActionType,			setNewSessionActionType,
	fetchNewCookieFromNativeCredentials,			fetchNewCookieFromNativeCredentials,
	createBoundServerCallsSelector,			createBoundServerCallsSelector,
	registerActiveSocket,			registerActiveSocket,
	useServerCall,			useServerCall,
	bindCookieAndUtilsIntoCallServerEndpoint,			bindCookieAndUtilsIntoCallServerEndpoint,
				extractKeyserverIDFromID,
	};			};

[native] [refactor] [ENG-530] refactor container margin bottom if statementClosedPublicActions