Paths

Table of Contentst

Differential D4013

[services] Rename PrimaryKey to PrimaryKeyDescriptor
ClosedPublic
Actions

Authored by • karol on May 12 2022, 2:04 AM.

Tags

None

Referenced Files

	F3536280: D4013.id12571.diff
	Wed, Dec 25, 6:07 PM

	F3536123: D4013.id12648.diff
	Wed, Dec 25, 5:36 PM

	F3530991: D4013.id12622.diff
	Wed, Dec 25, 5:31 AM

	Unknown Object (File)
	Thu, Dec 19, 11:55 PM

	Unknown Object (File)
	Thu, Dec 19, 11:55 PM

	Unknown Object (File)
	Thu, Dec 19, 11:55 PM

	Unknown Object (File)
	Thu, Dec 19, 11:55 PM

	Unknown Object (File)
	Thu, Dec 19, 11:50 PM

Subscribers

Details

Reviewers

• max
tomek

Commits

rCOMM284b813e673b: [services] Rename PrimaryKey to PrimaryKeyDescriptor

Summary

Depends on D3999

Raised in https://phabricator.ashoat.com/D3989#112043

Test Plan

Build the services

Diff Detail

Repository

Branch

tb

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.May 12 2022, 2:04 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 12 2022, 2:04 AM

• karol edited the summary of this revision. (Show Details)May 12 2022, 2:05 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: • max, tomek.

• karol added a parent revision: D3999: [services] consistently return when trying to remove non-existent item.

• karol mentioned this in D3989: [services] Lib - Tunnelbroker - Use sources.

Harbormaster completed remote builds in B9030: Diff 12571.May 12 2022, 2:11 AM

• karol requested review of this revision.May 12 2022, 2:11 AM

tomek requested changes to this revision.May 12 2022, 3:15 AM

tomek added inline comments.

services/lib/src/Item.h
29	Adding a `Name` doesn't sound right when it is a compound object containing partition and sort keys. What about `PrimaryKeyDescriptor`?

This revision now requires changes to proceed.May 12 2022, 3:15 AM

I don't mind, it can be "descriptor".

@geekbrother please share your opinion.

Requesting review so it goes to Max's queue.

In D4013#112592, @karol-bisztyga wrote:

I don't mind, it can be "descriptor".

@geekbrother please share your opinion.

Requesting review so it goes to Max's queue.

Accepting this diff, let's go with the "descriptor". Thanks for putting up these changes @karol-bisztyga !

This appeared in my queue because @geekbrother accepted, but the name still need to be changed

This revision now requires changes to proceed.May 13 2022, 2:23 AM

use "descriptor" instead of "name"

Harbormaster failed remote builds in B9076: Diff 12622!May 13 2022, 2:26 AM

tomek accepted this revision.May 13 2022, 2:31 AM

This revision is now accepted and ready to land.May 13 2022, 2:31 AM

• karol added a child revision: D4026: [services] Fix reactors - Initialize status holders.May 13 2022, 2:33 AM

• karol retitled this revision from [services] Rename PrimaryKey to PrimaryKeyName to [services] Rename PrimaryKey to PrimaryKeyDescriptor.May 13 2022, 4:29 AM

This revision was landed with ongoing or failed builds.May 13 2022, 4:30 AM

Closed by commit rCOMM284b813e673b: [services] Rename PrimaryKey to PrimaryKeyDescriptor (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM284b813e673b: [services] Rename PrimaryKey to PrimaryKeyDescriptor.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

DatabaseEntities/

2 lines

4 lines

2 lines

4 lines

blob/

src/

DatabaseEntities/

2 lines

4 lines

ReverseIndexItem.h

2 lines

ReverseIndexItem.cpp

4 lines

lib/

src/

DatabaseManagerBase.cpp

2 lines

4 lines

tunnelbroker/

src/

Database/

DeviceSessionItem.h

2 lines

DeviceSessionItem.cpp

4 lines

2 lines

MessageItem.cpp

4 lines

PublicKeyItem.h

2 lines

PublicKeyItem.cpp

4 lines

SessionSignItem.h

2 lines

SessionSignItem.cpp

4 lines

Diff 12571

services/backup/src/DatabaseEntities/BackupItem.h

Loading...

services/backup/src/DatabaseEntities/BackupItem.cpp

Loading...

services/backup/src/DatabaseEntities/LogItem.h

Loading...

services/backup/src/DatabaseEntities/LogItem.cpp

Loading...

services/blob/src/DatabaseEntities/BlobItem.h

Loading...

services/blob/src/DatabaseEntities/BlobItem.cpp

Loading...

services/blob/src/DatabaseEntities/ReverseIndexItem.h

Loading...

services/blob/src/DatabaseEntities/ReverseIndexItem.cpp

Loading...

services/lib/src/DatabaseManagerBase.cpp

Loading...

services/lib/src/Item.h

Loading...

services/tunnelbroker/src/Database/DeviceSessionItem.h

Loading...

services/tunnelbroker/src/Database/DeviceSessionItem.cpp

Loading...

services/tunnelbroker/src/Database/MessageItem.h

Loading...

services/tunnelbroker/src/Database/MessageItem.cpp

Loading...

services/tunnelbroker/src/Database/PublicKeyItem.h

Loading...

services/tunnelbroker/src/Database/PublicKeyItem.cpp

Loading...

services/tunnelbroker/src/Database/SessionSignItem.h

Loading...

services/tunnelbroker/src/Database/SessionSignItem.cpp

Loading...