Page MenuHomePhabricator
Differential D4031

[services] Backup - use generateHolder for new backup
ClosedPublic
Actions

Authored by • karol on May 13 2022, 2:27 AM.
Tags
None
Referenced Files
F3281112: D4031.id13104.diff
Sat, Nov 16, 9:33 AM
F3278287: D4031.id12944.diff
Sat, Nov 16, 8:16 AM
F3275476: D4031.diff
Sat, Nov 16, 7:06 AM
Unknown Object (File)
Tue, Nov 12, 1:46 AM
Unknown Object (File)
Mon, Nov 11, 3:51 AM
Unknown Object (File)
Thu, Nov 7, 8:12 AM
Unknown Object (File)
Tue, Nov 5, 3:23 PM
Unknown Object (File)
Oct 16 2024, 8:43 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
Commits
rCOMMb79c0f60b06f: [services] Backup - use generateHolder for new backup
Summary

Depends on D4030

https://linear.app/comm/issue/ENG-1128/implement-generating-holders

Test Plan

Run the blob service
Run the backup service
Use grpc-playground to make a call creating a new backup

See the generated holder in the database or log it out

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.May 13 2022, 2:27 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 13 2022, 2:27 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 13 2022, 2:28 AM
Harbormaster failed remote builds in B9082: Diff 12628!
• karol edited the summary of this revision. (Show Details)May 13 2022, 2:42 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D4030: [services] Backup - Implement generating holder.
• karol added a child revision: D4032: [services] Backup - use generateHolder for new log.
• karol requested review of this revision.May 13 2022, 2:52 AM

services build passed

tomek accepted this revision.May 17 2022, 3:43 AM
This revision is now accepted and ready to land.May 17 2022, 3:43 AM
• karol planned changes to this revision.May 19 2022, 4:52 AM
• karol added inline comments.
services/backup/src/Reactors/server/CreateNewBackupReactor.cpp
57

invalid order

• karol updated this revision to Diff 12944.May 19 2022, 4:53 AM
• karol edited the summary of this revision. (Show Details)

fix order

This revision is now accepted and ready to land.May 19 2022, 4:53 AM
Harbormaster completed remote builds in B9342: Diff 12944.May 19 2022, 5:14 AM
• karol updated this revision to Diff 13104.May 25 2022, 2:30 AM

rebase

Harbormaster completed remote builds in B9465: Diff 13104.May 25 2022, 2:37 AM
Closed by commit rCOMMb79c0f60b06f: [services] Backup - use generateHolder for new backup (authored by • karol). · Explain WhyMay 25 2022, 3:25 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMb79c0f60b06f: [services] Backup - use generateHolder for new backup.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
Reactors/
server/
2 lines

Diff 12628

View Options

services/backup/src/Reactors/server/CreateNewBackupReactor.cpp

Loading...