Page MenuHomePhabricator
Differential D4076

[services] Add attachment delimiter
ClosedPublic
Actions

Authored by • karol on May 19 2022, 3:01 AM.
Tags
None
Referenced Files
F3536290: D4076.id12920.diff
Wed, Dec 25, 6:10 PM
F3536262: D4076.id13113.diff
Wed, Dec 25, 6:01 PM
F3531159: D4076.diff
Wed, Dec 25, 6:27 AM
Unknown Object (File)
Fri, Dec 20, 10:34 AM
Unknown Object (File)
Fri, Dec 20, 6:37 AM
Unknown Object (File)
Mon, Dec 9, 6:58 AM
Unknown Object (File)
Sat, Nov 30, 6:58 AM
Unknown Object (File)
Thu, Nov 28, 3:36 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
Commits
rCOMM060c33cc3907: [services] Add attachment delimiter
Summary

Depends on D4075

Adding an attachment holders delimiter. Holders are built from:

  • hashes - these are hexadecimal values - 0 to 9 and A to F (or lower case)
  • uuid - also hexadecimal - 0 to 9 and A to F (or lower case)
  • ID_SEPARATOR - :

So it's impossible to have ; character that would not be a delimiter.

Test Plan

Services still build

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.May 19 2022, 3:01 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 19 2022, 3:01 AM
Harbormaster completed remote builds in B9319: Diff 12920.May 19 2022, 3:15 AM
• karol requested review of this revision.May 19 2022, 3:15 AM
• karol edited the summary of this revision. (Show Details)May 19 2022, 3:48 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D4075: [services] Backup - prevent sending logs for non-existing backups.
• karol added a child revision: D4077: [services] Backup - Convert attachment holders from vector to string.
tomek accepted this revision.May 23 2022, 4:40 AM
tomek added inline comments.
services/lib/src/GlobalConstants.h
25

Is it attachment-specific, or can be used to separate any id? Maybe we can rename it to ID_DELIMITER?

This revision is now accepted and ready to land.May 23 2022, 4:40 AM
• karol added inline comments.May 24 2022, 2:08 AM
services/lib/src/GlobalConstants.h
25

It's attachment-specific. Once we start using it with any other ids, we can rename it. It's crucial however to make sure that in the id pattern we want to use this, there's no way to have the delimiter character that could be a part of any id. In other words - if we use this delimiter for ids that are generated with the pattern that allows the delimiter character in the id, then we're lost. I explicitly made sure this delimiter will not occur in attachment ids.

ashoat added inline comments.May 24 2022, 11:00 AM
services/lib/src/GlobalConstants.h
25

Agree with @karol-bisztyga

Closed by commit rCOMM060c33cc3907: [services] Add attachment delimiter (authored by • karol). · Explain WhyMay 25 2022, 3:25 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM060c33cc3907: [services] Add attachment delimiter.

Revision Contents
Changeset List

PathSize
services/
lib/
src/
2 lines

Diff 12920

View Options

services/lib/src/GlobalConstants.h

Loading...