Page MenuHomePhabricator

[services] Backup - Create new backup - avoid suppressing database errors
ClosedPublic

Authored by karol on May 19 2022, 3:01 AM.
Tags
None
Referenced Files
F3260371: D4078.diff
Fri, Nov 15, 10:34 PM
Unknown Object (File)
Tue, Nov 5, 3:23 PM
Unknown Object (File)
Oct 13 2024, 2:01 PM
Unknown Object (File)
Oct 13 2024, 2:01 PM
Unknown Object (File)
Oct 13 2024, 2:00 PM
Unknown Object (File)
Oct 13 2024, 1:56 PM
Unknown Object (File)
Sep 13 2024, 1:17 AM
Unknown Object (File)
Sep 3 2024, 5:05 AM

Details

Summary

Depends on D4077

When creating a new backup I mistakenly just printed out database errors to stdout on the server. That led to an unwanted situation when something went wrong with the database and the client received a positive outcome. With this change, the error breaks uploading a new backup and the client receives proper information on what went wrong.

Test Plan

Services can still be built.

It's hard to really test this. In order to do this, we'd have to intentionally hardcode invalid instructions on the database and then see the result on the client-side.

You can do that, please see D4074 on how to test the services with the client.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage