Page MenuHomePhabricator
Differential D4079

[services] Backup - Database manager - Add findLogItem
ClosedPublic
Actions

Authored by • karol on May 19 2022, 3:02 AM.
Tags
None
Referenced Files
F3248308: D4079.diff
Fri, Nov 15, 9:08 AM
Unknown Object (File)
Tue, Nov 12, 2:49 PM
Unknown Object (File)
Thu, Nov 7, 4:18 PM
Unknown Object (File)
Tue, Nov 5, 3:14 PM
Unknown Object (File)
Oct 13 2024, 2:01 PM
Unknown Object (File)
Oct 13 2024, 2:01 PM
Unknown Object (File)
Oct 13 2024, 2:01 PM
Unknown Object (File)
Oct 13 2024, 2:01 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
Commits
rCOMMb25f0b3ef65f: [services] Backup - Database manager - Add findLogItem
Summary

Depends on D4078

Adding findLogItem method to the backup's database manager.

Test Plan

Services can still be built.

It's hard to really test this at this point. This method's going to be used later in the stack.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.May 19 2022, 3:02 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 19 2022, 3:02 AM
Harbormaster completed remote builds in B9322: Diff 12923.May 19 2022, 3:30 AM
• karol requested review of this revision.May 19 2022, 3:30 AM
• karol planned changes to this revision.May 19 2022, 3:55 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D4078: [services] Backup - Create new backup - avoid suppressing database errors.

Todo: I'm going to try to add this method to the backup's tests.

• karol added a child revision: D4080: [services] Backup - Add AddAttachment method.May 19 2022, 4:04 AM
• karol updated this revision to Diff 12937.May 19 2022, 4:38 AM
• karol edited the summary of this revision. (Show Details)

add this method to tests

Harbormaster completed remote builds in B9336: Diff 12937.May 19 2022, 4:51 AM
tomek requested changes to this revision.May 23 2022, 5:15 AM
tomek added inline comments.
services/backup/src/DatabaseManager.cpp
134

I think we concluded that we shouldn't move while returning. We're moveing in a couple of places in this file - could you check what's going on?

services/backup/test/DatabaseManagerTest.cpp
74–75

Can we check if the content of items matches?

This revision now requires changes to proceed.May 23 2022, 5:15 AM
• karol updated this revision to Diff 13051.May 24 2022, 2:46 AM

remove move

• karol planned changes to this revision.May 24 2022, 2:47 AM

test

Harbormaster completed remote builds in B9425: Diff 13051.May 24 2022, 2:53 AM
• karol updated this revision to Diff 13052.May 24 2022, 2:57 AM

check values in test

Harbormaster completed remote builds in B9426: Diff 13052.May 24 2022, 3:03 AM
tomek accepted this revision.May 24 2022, 3:32 AM
This revision is now accepted and ready to land.May 24 2022, 3:32 AM
Closed by commit rCOMMb25f0b3ef65f: [services] Backup - Database manager - Add findLogItem (authored by • karol). · Explain WhyMay 25 2022, 3:25 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMb25f0b3ef65f: [services] Backup - Database manager - Add findLogItem.
• karol removed a child revision: D4080: [services] Backup - Add AddAttachment method.May 26 2022, 3:08 AM

Revision Contents
Changeset List

PathSize
services/
backup/
src/
2 lines
13 lines
test/
10 lines

Diff 12937

View Options

services/backup/src/DatabaseManager.h

Loading...
View Options

services/backup/src/DatabaseManager.cpp

Loading...
View Options

services/backup/test/DatabaseManagerTest.cpp

Loading...