Page MenuHomePhabricator
Differential D4027

[services] Move generateUUID to global tools
ClosedPublic
Actions

Authored by • karol on May 13 2022, 2:25 AM.
Tags
None
Referenced Files
F2835055: D4027.diff
Sat, Sep 28, 12:33 PM
F2829553: D4027.diff
Fri, Sep 27, 4:53 PM
Unknown Object (File)
Wed, Sep 18, 11:48 PM
Unknown Object (File)
Sat, Sep 7, 3:23 AM
Unknown Object (File)
Tue, Sep 3, 5:46 AM
Unknown Object (File)
Tue, Sep 3, 5:46 AM
Unknown Object (File)
Tue, Sep 3, 5:46 AM
Unknown Object (File)
Tue, Sep 3, 5:40 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
Commits
rCOMMf997677296b6: [services] Move generateUUID to global tools
Summary

Depends on D4026

Extracting generateUUID from tunnelbroker into the global tools

Test Plan

Services still build

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.May 13 2022, 2:25 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 13 2022, 2:25 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 13 2022, 2:26 AM
Harbormaster failed remote builds in B9078: Diff 12624!
• karol edited the summary of this revision. (Show Details)May 13 2022, 2:33 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D4026: [services] Fix reactors - Initialize status holders.
• karol added a child revision: D4028: [services] Backup - generate backup id.
• karol requested review of this revision.May 13 2022, 2:50 AM

services build passed

tomek accepted this revision.May 17 2022, 3:11 AM
tomek added inline comments.
services/lib/src/GlobalTools.cpp
12–13 ↗(On Diff #12624)

If the tools are global, why are we using network namespace?

This revision is now accepted and ready to land.May 17 2022, 3:11 AM
• karol added inline comments.May 17 2022, 11:15 PM
services/lib/src/GlobalTools.cpp
12–13 ↗(On Diff #12624)

IIRC network is a namespace for the services basically.

tomek added inline comments.May 18 2022, 1:07 AM
services/lib/src/GlobalTools.cpp
12–13 ↗(On Diff #12624)

At some point it might be a good idea to find a name that better describes the purpose. It doesn't sound like network is the best namespace for all the services.

• karol added inline comments.May 19 2022, 2:18 AM
services/lib/src/GlobalTools.cpp
12–13 ↗(On Diff #12624)

Sure, we can rename it, I don't mind
https://linear.app/comm/issue/ENG-1162/think-of-the-best-namespace-name

This revision was landed with ongoing or failed builds.May 19 2022, 4:42 AM
Closed by commit rCOMMf997677296b6: [services] Move generateUUID to global tools (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMf997677296b6: [services] Move generateUUID to global tools.

Revision Contents
Changeset List

PathSize
services/
lib/
src/
2 lines
8 lines
tunnelbroker/
src/
Service/
5 lines
Tools/
1 line
8 lines
test/
3 lines
3 lines
3 lines
3 lines

Diff 12939

View Options

services/lib/src/GlobalTools.h

Loading...
View Options

services/lib/src/GlobalTools.cpp

Loading...
View Options

services/tunnelbroker/src/Service/TunnelbrokerServiceImpl.cpp

Loading...
View Options

services/tunnelbroker/src/Tools/Tools.h

Loading...
View Options

services/tunnelbroker/src/Tools/Tools.cpp

Loading...
View Options

services/tunnelbroker/test/AmqpManagerTest.cpp

Loading...
View Options

services/tunnelbroker/test/DatabaseManagerTest.cpp

Loading...
View Options

services/tunnelbroker/test/DeliveryBrokerTest.cpp

Loading...
View Options

services/tunnelbroker/test/ToolsTest.cpp

Loading...