[keyserver] Introduce getDBType function to distinguish MySQL and MariaDB
ClosedPublic
Actions

Authored by ashoat on Jul 13 2022, 8:40 AM.

Details

Reviewers

atul
tomek
• jon

Commits

rCOMMe2cb36c1a0d9: [keyserver] Introduce getDBType function to distinguish MySQL and MariaDB

Summary

Depends on D4516

Test Plan

Tested in combination with next diffs

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/mariadb

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jul 13 2022, 8:40 AM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJul 13 2022, 8:40 AM

Harbormaster completed remote builds in B10490: Diff 14437.Jul 13 2022, 8:53 AM

ashoat requested review of this revision.Jul 13 2022, 8:53 AM

ashoat added a child revision: D4519: [keyserver] Make rawMessageInfoFromRows return a Promise.Jul 13 2022, 9:08 AM

Not super qualified to review js, but doesn't look wrong in any regards

atul accepted this revision.Jul 15 2022, 12:18 PM

This revision is now accepted and ready to land.Jul 15 2022, 12:18 PM

Closed by commit rCOMMe2cb36c1a0d9: [keyserver] Introduce getDBType function to distinguish MySQL and MariaDB (authored by ashoat). · Explain WhyJul 17 2022, 8:13 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe2cb36c1a0d9: [keyserver] Introduce getDBType function to distinguish MySQL and MariaDB.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

database/

db-config.js

10 lines

Diff 14437

View Options

keyserver/src/database/db-config.js

	// @flow			// @flow

	import uuid from 'uuid';			import uuid from 'uuid';

	import blobService from '../facts/blob-service.js';			import blobService from '../facts/blob-service.js';
	import type { Shape } from '../types/core.js';
	import type { UploadMultimediaResult, Dimensions } from '../types/media-types';			import type { UploadMultimediaResult, Dimensions } from '../types/media-types';
	import { extractKeyserverIDFromID } from '../utils/action-utils.js';			import { extractKeyserverIDFromID } from '../utils/action-utils.js';
	import { toBase64URL } from '../utils/base64.js';			import { toBase64URL } from '../utils/base64.js';
	import {			import {
	blobServiceUploadHandler,			blobServiceUploadHandler,
	type BlobServiceUploadHandler,			type BlobServiceUploadHandler,
	} from '../utils/blob-service-upload.js';			} from '../utils/blob-service-upload.js';
	import { makeBlobServiceEndpointURL } from '../utils/blob-service.js';			import { makeBlobServiceEndpointURL } from '../utils/blob-service.js';
	import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';			import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
	import { getMessageForException } from '../utils/errors.js';			import { getMessageForException } from '../utils/errors.js';
	import { useKeyserverCall } from '../utils/keyserver-call.js';			import { useKeyserverCall } from '../utils/keyserver-call.js';
	import type { CallKeyserverEndpoint } from '../utils/keyserver-call.js';			import type { CallKeyserverEndpoint } from '../utils/keyserver-call.js';
	import { handleHTTPResponseError } from '../utils/services-utils.js';			import { handleHTTPResponseError } from '../utils/services-utils.js';
	import { type UploadBlob } from '../utils/upload-blob.js';			import { type UploadBlob } from '../utils/upload-blob.js';

	export type MultimediaUploadCallbacks = Shape<{			export type MultimediaUploadCallbacks = Partial<{
	onProgress: (percent: number) => void,			+onProgress: (percent: number) => void,
	abortHandler: (abort: () => void) => void,			+abortHandler: (abort: () => void) => void,
	uploadBlob: UploadBlob,			+uploadBlob: UploadBlob,
	blobServiceUploadHandler: BlobServiceUploadHandler,			+blobServiceUploadHandler: BlobServiceUploadHandler,
	timeout: ?number,			+timeout: ?number,
	}>;			}>;
	export type MultimediaUploadExtras = Shape<{			export type MultimediaUploadExtras = $ReadOnly<Partial<{
	...Dimensions,			...Dimensions,
	loop: boolean,			+loop: boolean,
	encryptionKey: string,			+encryptionKey: string,
	thumbHash: ?string,			+thumbHash: ?string,
	}>;			}>>;

	const uploadMultimedia =			const uploadMultimedia =
	(			(
	callServerEndpoint: CallServerEndpoint,			callServerEndpoint: CallServerEndpoint,
	): ((			): ((
	multimedia: Object,			multimedia: Object,
	extras: MultimediaUploadExtras,			extras: MultimediaUploadExtras,
	callbacks?: MultimediaUploadCallbacks,			callbacks?: MultimediaUploadCallbacks,
	▲ Show 20 Lines • Show All 208 Lines • Show Last 20 Lines

[keyserver] Introduce getDBType function to distinguish MySQL and MariaDBClosedPublicActions