Page MenuHomePhabricator

[keyserver] Make rawMessageInfoFromRows return a Promise
ClosedPublic

Authored by ashoat on Jul 13 2022, 9:08 AM.
Tags
None
Referenced Files
F3374061: D4519.id14438.diff
Tue, Nov 26, 1:34 PM
Unknown Object (File)
Sat, Nov 23, 11:21 PM
Unknown Object (File)
Fri, Nov 22, 11:42 PM
Unknown Object (File)
Fri, Nov 22, 10:53 PM
Unknown Object (File)
Fri, Nov 22, 7:42 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM

Details

Summary

In D4521 we end up needing to await getDBType() in the message-fetchers.js code because we need to parse the query results differently depending on whether it came from MySQL 5.7 or MariaDB 10.8.

Depends on D4518

Test Plan

Flow; tested in combination with next diffs

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/mariadb
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Not super qualified to review js, but the intention looks right

The change makes sense, but explaining the higher level motivation in the Summary section could be helpful

keyserver/src/fetchers/message-fetchers.js
138

Maybe parsedMessages instead of parseResults, but doesn't really matter

193–196

My personal preference would be something a little less verbose like:

return !rawMessageInfo ? null : { rawMessageInfo, rows: messageRows };

But I know everyone has an opinion on when/where to use ternaries, so feel free to disregard.

This revision is now accepted and ready to land.Jul 15 2022, 12:39 PM