Paths

Table of Contentst

[keyserver] Make mediaFromRow return a Promise
ClosedPublic
Actions

Authored by ashoat on Jul 13 2022, 9:24 AM.

Details

Reviewers

atul
tomek
• jon

Commits

rCOMMc9c5ad27ff0b: [keyserver] Make mediaFromRow return a Promise

Summary

In D4521 we end up needing to await getDBType() in the message-fetchers.js code because we need to parse the query results differently depending on whether it came from MySQL 5.7 or MariaDB 10.8.

Depends on D4519

Test Plan

Flow; tested in combination with next diffs

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/mariadb

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jul 13 2022, 9:24 AM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJul 13 2022, 9:24 AM

Harbormaster completed remote builds in B10492: Diff 14439.Jul 13 2022, 9:34 AM

ashoat requested review of this revision.Jul 13 2022, 9:34 AM

ashoat added a child revision: D4521: [keyserver] Parse JSON columns returned from MariaDB.Jul 13 2022, 10:36 AM

Not super qualified to review js

Same as D4519:

The change makes sense, but explaining the higher level motivation in the Summary section could be helpful

This revision is now accepted and ready to land.Jul 15 2022, 12:46 PM

ashoat edited the summary of this revision. (Show Details)Jul 17 2022, 7:44 AM

Closed by commit rCOMMc9c5ad27ff0b: [keyserver] Make mediaFromRow return a Promise (authored by ashoat). · Explain WhyJul 17 2022, 8:13 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMc9c5ad27ff0b: [keyserver] Make mediaFromRow return a Promise.

ashoat added a reverting change: D4834: [keyserver] Move mediaFromRow and rawMessageInfoFromRows back to not return a Promise.Aug 15 2022, 12:38 PM

ashoat added a reverting change: rCOMM47dfd97cde84: [keyserver] Move mediaFromRow and rawMessageInfoFromRows back to not return a….Aug 16 2022, 6:14 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

message-fetchers.js

4 lines

upload-fetchers.js

4 lines

Diff 14439

View Options

keyserver/src/fetchers/message-fetchers.js