Make blob more nix friendly
and make use of the native/cpp cmake work
DatabaseEntitiesTools.h was moved to lib/src as it was largely duplicated across three projects
Backup docker + cmake is fixed in D4494
Paths
| Differential D4493 Authored by • jon on Jul 8 2022, 10:58 PM.
Tags None Referenced Files
Details
Summary Make blob more nix friendly DatabaseEntitiesTools.h was moved to lib/src as it was largely duplicated across three projects Backup docker + cmake is fixed in D4494 Test Plan nix develop cd services/blob && mkdir build && cd build && cmake .. && make docker: cd services/base-image docker build -t commapp/services-base . -f Dockerfile cd ../.. docker build . -f services/blob/Dockerfile
Diff Detail
Event TimelineHerald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 8 2022, 10:58 PM2022-07-08 22:58:52 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Jul 8 2022, 11:00 PM2022-07-08 23:00:19 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2022, 9:05 PM2022-07-25 21:05:44 (UTC-7) • jon added a parent revision: D4490: [Services] Adjust tunnelbroker with CMake changes.Jul 26 2022, 8:23 AM2022-07-26 08:23:53 (UTC-7) • jon edited parent revisions, added: D4489: [Services] Export shared services cpp as CMake Project; removed: D4490: [Services] Adjust tunnelbroker with CMake changes.Jul 28 2022, 6:27 PM2022-07-28 18:27:35 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2022, 9:52 AM2022-07-29 09:52:43 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2022, 3:05 PM2022-07-29 15:05:13 (UTC-7) • jon edited the test plan for this revision. (Show Details)Jul 29 2022, 4:06 PM2022-07-29 16:06:27 (UTC-7) • jon edited the summary of this revision. (Show Details)Jul 29 2022, 4:10 PM2022-07-29 16:10:27 (UTC-7) Comment Actions
Is there an ETA for that? Should I review this diff right now, or should I put it back on your queue until it's ready? This revision now requires changes to proceed.Aug 1 2022, 7:04 AM2022-08-01 07:04:26 (UTC-7) Comment Actions The test plan doesn't need dockerhub. And waiting for the base image diff to be approved before pushing https://phab.comm.dev/D4630 Comment Actions cd services/base-image docker build -t commapp/services-base . -f Dockerfile cd ../.. docker build . -f services/blob/Dockerfile Tested this locally and it build successfully This revision is now accepted and ready to land.Aug 1 2022, 8:59 AM2022-08-01 08:59:07 (UTC-7) Harbormaster failed remote builds in B11024: Diff 15165!Aug 1 2022, 12:48 PM2022-08-01 12:48:40 (UTC-7) • jon removed a parent revision: D4687: [Services] Prune duplicated DatabaseEntitiesTools.h.Aug 1 2022, 1:01 PM2022-08-01 13:01:58 (UTC-7) Harbormaster failed remote builds in B11033: Diff 15174!Aug 1 2022, 1:25 PM2022-08-01 13:25:16 (UTC-7) • jon retitled this revision from [Services] Export blob as CMake project to [Services] Update blob CMake project.Aug 1 2022, 1:39 PM2022-08-01 13:39:20 (UTC-7) Harbormaster failed remote builds in B11105: Diff 15296!Aug 3 2022, 11:25 PM2022-08-03 23:25:55 (UTC-7) Comment Actions I was going to try and fix this by doing the header additions first, but I realize I really can't with #include "DatabaseEntitiesTools.h" still needing to be somewhere. • jon added a parent revision: D4762: [Services] Allow blob to be built on MacOS.Aug 5 2022, 4:46 PM2022-08-05 16:46:46 (UTC-7) Harbormaster failed remote builds in B11184: Diff 15391!Aug 5 2022, 5:17 PM2022-08-05 17:17:13 (UTC-7) This comment was removed by atul. This revision now requires changes to proceed.Aug 8 2022, 10:40 AM2022-08-08 10:40:26 (UTC-7) Comment Actions Sorry just checked and looks like the Test Plan here continues to work, intended to request changes on D4762 This revision is now accepted and ready to land.Aug 8 2022, 10:43 AM2022-08-08 10:43:49 (UTC-7) Harbormaster failed remote builds in B11222: Diff 15440!Aug 8 2022, 11:44 AM2022-08-08 11:44:50 (UTC-7) This revision was landed with ongoing or failed builds.Aug 8 2022, 1:45 PM2022-08-08 13:45:27 (UTC-7) Closed by commit rCOMMc11d07fedc73: [Services] Update blob CMake project (authored by • jon). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 15107 services/blob/CMakeLists.txt
services/blob/Dockerfile
services/blob/src/BlobServiceImpl.h
services/blob/src/DatabaseEntities/DatabaseEntitiesTools.h
services/blob/src/DatabaseManager.h
services/blob/src/Reactors/server/GetReactor.h
services/blob/src/Tools.h
|