[Services] Make build_service.sh PWD independent
ClosedPublic
Actions

Authored by • jon on Jul 29 2022, 3:00 PM.

Details

Reviewers

Commits

Summary

This allows for the script to be invoked from another directory
Nice quality of docker scripts to avoid having to issue another WORKDIR.

Also should allow for dev workflow to call script from anywhere (including root)

Depends on D4684

Test Plan

Follow test plan from blob or backup diff in this stack

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

• jon requested review of this revision.Jul 29 2022, 3:12 PM

Just a basic review using ShellCheck. Will get it added to the CI soon, sorry for the delay!

services/lib/docker/build_service.sh
11–13 ↗	(On Diff #15116)	This ln has no destination. Check the arguments, or specify . explicitly.
24–25 ↗	(On Diff #15116)	Double quote to prevent globbing and word splitting.

This revision now requires changes to proceed.Jul 30 2022, 8:53 AM

• jon marked an inline comment as done.Jul 31 2022, 8:24 AM

• jon added inline comments.

services/lib/docker/build_service.sh
11–13 ↗	(On Diff #15116)	I remove all of this in https://phab.comm.dev/D4671
24–25 ↗	(On Diff #15116)	Fair enough

Double quote SCRIPT_DIR

Address comments

Look ok to me.

services/lib/docker/build_service.sh
22	Not sure we need this comment.

Nice!

• jon marked an inline comment as done.Aug 2 2022, 1:26 PM

• jon added inline comments.

services/lib/docker/build_service.sh
22	The command is very... unusual. So I would like to keep the comment. Eventually we should be able to get rid of calling the other scripts altogether.