Page MenuHomePhabricator
Differential D5763

[native] Pass TextMessage.onPress down via context
ClosedPublic
Actions

Authored by ashoat on Nov 29 2022, 8:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 4:16 AM
Unknown Object (File)
Mon, Mar 17, 4:16 AM
Unknown Object (File)
Mon, Mar 17, 4:16 AM
Unknown Object (File)
Mon, Mar 17, 4:13 AM
Unknown Object (File)
Fri, Mar 7, 8:57 PM
Unknown Object (File)
Mar 1 2025, 7:54 AM
Unknown Object (File)
Feb 24 2025, 9:30 AM
Unknown Object (File)
Jan 29 2025, 12:41 AM
View All Files
Subscribers
tomek

Details

Reviewers
rohan
atul
ginsu
michal
Commits
rCOMMb589a7bbd40b: [native] Pass TextMessage.onPress down via context
Summary

Descendants of this component will need to call onPress.

Test Plan

I tested this in combination with the next diff. See attached video in the next diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 18985

View Options

native/chat/message-press-responder-context.js

// @flow // @flow
import type { MinimallyEncodedRawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import invariant from 'invariant';
import { decodeMinimallyEncodedRawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { minimallyEncodedMemberInfoValidator } from '../permissions/minimally-encoded-thread-permissions-validators.js';
import type {
MinimallyEncodedMemberInfo,
MinimallyEncodedRawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js';
import {
decodeMinimallyEncodedRawThreadInfo,
minimallyEncodeMemberInfo,
} from '../types/minimally-encoded-thread-permissions-types.js';
import { assertThreadType } from '../types/thread-types-enum.js'; import { assertThreadType } from '../types/thread-types-enum.js';
import { import {
type ClientDBThreadInfo, type ClientDBThreadInfo,
legacyMemberInfoValidator,
type LegacyRawThreadInfo, type LegacyRawThreadInfo,
type RawThreadInfo, type RawThreadInfo,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
function convertRawThreadInfoToClientDBThreadInfo( function convertRawThreadInfoToClientDBThreadInfo(
rawThreadInfo: RawThreadInfo, rawThreadInfo: RawThreadInfo,
): ClientDBThreadInfo { ): ClientDBThreadInfo {
const { minimallyEncoded, ...rest } = rawThreadInfo; const { minimallyEncoded, ...rest } = rawThreadInfo;
return { return {
...rest, ...rest,
creationTime: rawThreadInfo.creationTime.toString(), creationTime: rawThreadInfo.creationTime.toString(),
members: JSON.stringify(rawThreadInfo.members), members: JSON.stringify(rawThreadInfo.members),
roles: JSON.stringify(rawThreadInfo.roles), roles: JSON.stringify(rawThreadInfo.roles),
currentUser: JSON.stringify(rawThreadInfo.currentUser), currentUser: JSON.stringify(rawThreadInfo.currentUser),
avatar: rawThreadInfo.avatar ? JSON.stringify(rawThreadInfo.avatar) : null, avatar: rawThreadInfo.avatar ? JSON.stringify(rawThreadInfo.avatar) : null,
}; };
} }
function convertClientDBThreadInfoToRawThreadInfo( function convertClientDBThreadInfoToRawThreadInfo(
clientDBThreadInfo: ClientDBThreadInfo, clientDBThreadInfo: ClientDBThreadInfo,
): MinimallyEncodedRawThreadInfo { ): MinimallyEncodedRawThreadInfo {
// 1. Validate and potentially minimally encode `rawMembers`.
const rawMembers = JSON.parse(clientDBThreadInfo.members);
const minimallyEncodedMembers: $ReadOnlyArray<MinimallyEncodedMemberInfo> =
rawMembers.map(rawMember => {
invariant(
minimallyEncodedMemberInfoValidator.is(rawMember) ||
legacyMemberInfoValidator.is(rawMember),
'rawMember must be valid [MinimallyEncoded/Legacy]MemberInfo',
);
return rawMember.minimallyEncoded
? rawMember
: minimallyEncodeMemberInfo(rawMember);
});
let rawThreadInfo: MinimallyEncodedRawThreadInfo = { let rawThreadInfo: MinimallyEncodedRawThreadInfo = {
minimallyEncoded: true, minimallyEncoded: true,
id: clientDBThreadInfo.id, id: clientDBThreadInfo.id,
type: assertThreadType(clientDBThreadInfo.type), type: assertThreadType(clientDBThreadInfo.type),
name: clientDBThreadInfo.name, name: clientDBThreadInfo.name,
description: clientDBThreadInfo.description, description: clientDBThreadInfo.description,
color: clientDBThreadInfo.color, color: clientDBThreadInfo.color,
creationTime: Number(clientDBThreadInfo.creationTime), creationTime: Number(clientDBThreadInfo.creationTime),
parentThreadID: clientDBThreadInfo.parentThreadID, parentThreadID: clientDBThreadInfo.parentThreadID,
containingThreadID: clientDBThreadInfo.containingThreadID, containingThreadID: clientDBThreadInfo.containingThreadID,
community: clientDBThreadInfo.community, community: clientDBThreadInfo.community,
members: JSON.parse(clientDBThreadInfo.members), members: minimallyEncodedMembers,
roles: JSON.parse(clientDBThreadInfo.roles), roles: JSON.parse(clientDBThreadInfo.roles),
currentUser: JSON.parse(clientDBThreadInfo.currentUser), currentUser: JSON.parse(clientDBThreadInfo.currentUser),
repliesCount: clientDBThreadInfo.repliesCount, repliesCount: clientDBThreadInfo.repliesCount,
pinnedCount: clientDBThreadInfo.pinnedCount, pinnedCount: clientDBThreadInfo.pinnedCount,
}; };
if (clientDBThreadInfo.sourceMessageID) { if (clientDBThreadInfo.sourceMessageID) {
rawThreadInfo = { rawThreadInfo = {
Show All 31 Lines
View Options

native/chat/text-message-tooltip-button.react.js

// @flow // @flow
import type { MinimallyEncodedRawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import invariant from 'invariant';
import { decodeMinimallyEncodedRawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { minimallyEncodedMemberInfoValidator } from '../permissions/minimally-encoded-thread-permissions-validators.js';
import type {
MinimallyEncodedMemberInfo,
MinimallyEncodedRawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js';
import {
decodeMinimallyEncodedRawThreadInfo,
minimallyEncodeMemberInfo,
} from '../types/minimally-encoded-thread-permissions-types.js';
import { assertThreadType } from '../types/thread-types-enum.js'; import { assertThreadType } from '../types/thread-types-enum.js';
import { import {
type ClientDBThreadInfo, type ClientDBThreadInfo,
legacyMemberInfoValidator,
type LegacyRawThreadInfo, type LegacyRawThreadInfo,
type RawThreadInfo, type RawThreadInfo,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
function convertRawThreadInfoToClientDBThreadInfo( function convertRawThreadInfoToClientDBThreadInfo(
rawThreadInfo: RawThreadInfo, rawThreadInfo: RawThreadInfo,
): ClientDBThreadInfo { ): ClientDBThreadInfo {
const { minimallyEncoded, ...rest } = rawThreadInfo; const { minimallyEncoded, ...rest } = rawThreadInfo;
return { return {
...rest, ...rest,
creationTime: rawThreadInfo.creationTime.toString(), creationTime: rawThreadInfo.creationTime.toString(),
members: JSON.stringify(rawThreadInfo.members), members: JSON.stringify(rawThreadInfo.members),
roles: JSON.stringify(rawThreadInfo.roles), roles: JSON.stringify(rawThreadInfo.roles),
currentUser: JSON.stringify(rawThreadInfo.currentUser), currentUser: JSON.stringify(rawThreadInfo.currentUser),
avatar: rawThreadInfo.avatar ? JSON.stringify(rawThreadInfo.avatar) : null, avatar: rawThreadInfo.avatar ? JSON.stringify(rawThreadInfo.avatar) : null,
}; };
} }
function convertClientDBThreadInfoToRawThreadInfo( function convertClientDBThreadInfoToRawThreadInfo(
clientDBThreadInfo: ClientDBThreadInfo, clientDBThreadInfo: ClientDBThreadInfo,
): MinimallyEncodedRawThreadInfo { ): MinimallyEncodedRawThreadInfo {
// 1. Validate and potentially minimally encode `rawMembers`.
const rawMembers = JSON.parse(clientDBThreadInfo.members);
const minimallyEncodedMembers: $ReadOnlyArray<MinimallyEncodedMemberInfo> =
rawMembers.map(rawMember => {
invariant(
minimallyEncodedMemberInfoValidator.is(rawMember) ||
legacyMemberInfoValidator.is(rawMember),
'rawMember must be valid [MinimallyEncoded/Legacy]MemberInfo',
);
return rawMember.minimallyEncoded
? rawMember
: minimallyEncodeMemberInfo(rawMember);
});
let rawThreadInfo: MinimallyEncodedRawThreadInfo = { let rawThreadInfo: MinimallyEncodedRawThreadInfo = {
minimallyEncoded: true, minimallyEncoded: true,
id: clientDBThreadInfo.id, id: clientDBThreadInfo.id,
type: assertThreadType(clientDBThreadInfo.type), type: assertThreadType(clientDBThreadInfo.type),
name: clientDBThreadInfo.name, name: clientDBThreadInfo.name,
description: clientDBThreadInfo.description, description: clientDBThreadInfo.description,
color: clientDBThreadInfo.color, color: clientDBThreadInfo.color,
creationTime: Number(clientDBThreadInfo.creationTime), creationTime: Number(clientDBThreadInfo.creationTime),
parentThreadID: clientDBThreadInfo.parentThreadID, parentThreadID: clientDBThreadInfo.parentThreadID,
containingThreadID: clientDBThreadInfo.containingThreadID, containingThreadID: clientDBThreadInfo.containingThreadID,
community: clientDBThreadInfo.community, community: clientDBThreadInfo.community,
members: JSON.parse(clientDBThreadInfo.members), members: minimallyEncodedMembers,
roles: JSON.parse(clientDBThreadInfo.roles), roles: JSON.parse(clientDBThreadInfo.roles),
currentUser: JSON.parse(clientDBThreadInfo.currentUser), currentUser: JSON.parse(clientDBThreadInfo.currentUser),
repliesCount: clientDBThreadInfo.repliesCount, repliesCount: clientDBThreadInfo.repliesCount,
pinnedCount: clientDBThreadInfo.pinnedCount, pinnedCount: clientDBThreadInfo.pinnedCount,
}; };
if (clientDBThreadInfo.sourceMessageID) { if (clientDBThreadInfo.sourceMessageID) {
rawThreadInfo = { rawThreadInfo = {
Show All 31 Lines
View Options

native/chat/text-message.react.js

// @flow // @flow
import type { MinimallyEncodedRawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import invariant from 'invariant';
import { decodeMinimallyEncodedRawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { minimallyEncodedMemberInfoValidator } from '../permissions/minimally-encoded-thread-permissions-validators.js';
import type {
MinimallyEncodedMemberInfo,
MinimallyEncodedRawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js';
import {
decodeMinimallyEncodedRawThreadInfo,
minimallyEncodeMemberInfo,
} from '../types/minimally-encoded-thread-permissions-types.js';
import { assertThreadType } from '../types/thread-types-enum.js'; import { assertThreadType } from '../types/thread-types-enum.js';
import { import {
type ClientDBThreadInfo, type ClientDBThreadInfo,
legacyMemberInfoValidator,
type LegacyRawThreadInfo, type LegacyRawThreadInfo,
type RawThreadInfo, type RawThreadInfo,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
function convertRawThreadInfoToClientDBThreadInfo( function convertRawThreadInfoToClientDBThreadInfo(
rawThreadInfo: RawThreadInfo, rawThreadInfo: RawThreadInfo,
): ClientDBThreadInfo { ): ClientDBThreadInfo {
const { minimallyEncoded, ...rest } = rawThreadInfo; const { minimallyEncoded, ...rest } = rawThreadInfo;
return { return {
...rest, ...rest,
creationTime: rawThreadInfo.creationTime.toString(), creationTime: rawThreadInfo.creationTime.toString(),
members: JSON.stringify(rawThreadInfo.members), members: JSON.stringify(rawThreadInfo.members),
roles: JSON.stringify(rawThreadInfo.roles), roles: JSON.stringify(rawThreadInfo.roles),
currentUser: JSON.stringify(rawThreadInfo.currentUser), currentUser: JSON.stringify(rawThreadInfo.currentUser),
avatar: rawThreadInfo.avatar ? JSON.stringify(rawThreadInfo.avatar) : null, avatar: rawThreadInfo.avatar ? JSON.stringify(rawThreadInfo.avatar) : null,
}; };
} }
function convertClientDBThreadInfoToRawThreadInfo( function convertClientDBThreadInfoToRawThreadInfo(
clientDBThreadInfo: ClientDBThreadInfo, clientDBThreadInfo: ClientDBThreadInfo,
): MinimallyEncodedRawThreadInfo { ): MinimallyEncodedRawThreadInfo {
// 1. Validate and potentially minimally encode `rawMembers`.
const rawMembers = JSON.parse(clientDBThreadInfo.members);
const minimallyEncodedMembers: $ReadOnlyArray<MinimallyEncodedMemberInfo> =
rawMembers.map(rawMember => {
invariant(
minimallyEncodedMemberInfoValidator.is(rawMember) ||
legacyMemberInfoValidator.is(rawMember),
'rawMember must be valid [MinimallyEncoded/Legacy]MemberInfo',
);
return rawMember.minimallyEncoded
? rawMember
: minimallyEncodeMemberInfo(rawMember);
});
let rawThreadInfo: MinimallyEncodedRawThreadInfo = { let rawThreadInfo: MinimallyEncodedRawThreadInfo = {
minimallyEncoded: true, minimallyEncoded: true,
id: clientDBThreadInfo.id, id: clientDBThreadInfo.id,
type: assertThreadType(clientDBThreadInfo.type), type: assertThreadType(clientDBThreadInfo.type),
name: clientDBThreadInfo.name, name: clientDBThreadInfo.name,
description: clientDBThreadInfo.description, description: clientDBThreadInfo.description,
color: clientDBThreadInfo.color, color: clientDBThreadInfo.color,
creationTime: Number(clientDBThreadInfo.creationTime), creationTime: Number(clientDBThreadInfo.creationTime),
parentThreadID: clientDBThreadInfo.parentThreadID, parentThreadID: clientDBThreadInfo.parentThreadID,
containingThreadID: clientDBThreadInfo.containingThreadID, containingThreadID: clientDBThreadInfo.containingThreadID,
community: clientDBThreadInfo.community, community: clientDBThreadInfo.community,
members: JSON.parse(clientDBThreadInfo.members), members: minimallyEncodedMembers,
roles: JSON.parse(clientDBThreadInfo.roles), roles: JSON.parse(clientDBThreadInfo.roles),
currentUser: JSON.parse(clientDBThreadInfo.currentUser), currentUser: JSON.parse(clientDBThreadInfo.currentUser),
repliesCount: clientDBThreadInfo.repliesCount, repliesCount: clientDBThreadInfo.repliesCount,
pinnedCount: clientDBThreadInfo.pinnedCount, pinnedCount: clientDBThreadInfo.pinnedCount,
}; };
if (clientDBThreadInfo.sourceMessageID) { if (clientDBThreadInfo.sourceMessageID) {
rawThreadInfo = { rawThreadInfo = {
Show All 31 Lines