Page MenuHomePhabricator
Differential D5765

[native] Normalize Android MarkdownLink behavior to match iOS
ClosedPublic
Actions

Authored by ashoat on Nov 29 2022, 8:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 12:57 PM
Unknown Object (File)
Sun, Apr 20, 3:21 AM
Unknown Object (File)
Sun, Apr 20, 2:53 AM
Unknown Object (File)
Sat, Apr 19, 7:26 AM
Unknown Object (File)
Sun, Apr 13, 5:36 PM
Unknown Object (File)
Sun, Apr 13, 5:36 PM
Unknown Object (File)
Sun, Apr 13, 5:36 PM
Unknown Object (File)
Sun, Apr 13, 5:36 PM
View All Files
Subscribers
tomek

Details

Reviewers
rohan
atul
ginsu
michal
Commits
rCOMM7988ebdc2edd: [native] Normalize Android MarkdownLink behavior to match iOS
Test Plan

I tested this on iOS and Android while pressing all over a message, before and after opening the modal. See attached video in previous diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
chat/
12 lines
markdown/
1 line
38 lines

Diff 18987

View Options

native/chat/text-message.react.js

Show All 19 Linesimport {
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesfunction useCreateChatThreadItem(): ThreadInfo => ChatThreadItem {
const getLastUpdatedTimes = useGetLastUpdatedTimes(); const getLastUpdatedTimes = useGetLastUpdatedTimes();
return React.useCallback( return React.useCallback(
threadInfo => { threadInfo => {
const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID( const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID(
threadInfo.id, threadInfo.id,
messageStore, messageStore,
); );
const { lastUpdatedAtLeastTime: lastUpdatedTime } = getLastUpdatedTimes( const { lastUpdatedAtLeastTime } = getLastUpdatedTimes(
threadInfo, threadInfo,
messageStore, messageStore,
messageInfos, messageInfos,
); );
const sidebars = sidebarInfos[threadInfo.id] ?? []; const sidebars = sidebarInfos[threadInfo.id] ?? [];
const allSidebarItems = sidebars.map(sidebarInfo => ({ const lastUpdatedAtLeastTimeIncludingSidebars =
type: 'sidebar', sidebars.length > 0
...sidebarInfo, ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
})); : lastUpdatedAtLeastTime;
const lastUpdatedTimeIncludingSidebars =
allSidebarItems.length > 0
? Math.max(lastUpdatedTime, allSidebarItems[0].lastUpdatedTime)
: lastUpdatedTime;
const sidebarItems = getSidebarItems(allSidebarItems); const allInitialSidebarItems = getAllInitialSidebarItems(sidebars);
const sidebarItems = getSidebarItems(allInitialSidebarItems);
return { return {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
lastUpdatedTime, lastUpdatedTime: lastUpdatedAtLeastTime,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars:
lastUpdatedAtLeastTimeIncludingSidebars,
sidebars: sidebarItems, sidebars: sidebarItems,
}; };
}, },
[messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes], [messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes],
); );
} }
function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> { function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> {
▲ Show 20 Lines • Show All 488 Lines • Show Last 20 Lines
View Options

native/markdown/markdown-link-context.js

Show All 19 Linesimport {
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesfunction useCreateChatThreadItem(): ThreadInfo => ChatThreadItem {
const getLastUpdatedTimes = useGetLastUpdatedTimes(); const getLastUpdatedTimes = useGetLastUpdatedTimes();
return React.useCallback( return React.useCallback(
threadInfo => { threadInfo => {
const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID( const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID(
threadInfo.id, threadInfo.id,
messageStore, messageStore,
); );
const { lastUpdatedAtLeastTime: lastUpdatedTime } = getLastUpdatedTimes( const { lastUpdatedAtLeastTime } = getLastUpdatedTimes(
threadInfo, threadInfo,
messageStore, messageStore,
messageInfos, messageInfos,
); );
const sidebars = sidebarInfos[threadInfo.id] ?? []; const sidebars = sidebarInfos[threadInfo.id] ?? [];
const allSidebarItems = sidebars.map(sidebarInfo => ({ const lastUpdatedAtLeastTimeIncludingSidebars =
type: 'sidebar', sidebars.length > 0
...sidebarInfo, ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
})); : lastUpdatedAtLeastTime;
const lastUpdatedTimeIncludingSidebars =
allSidebarItems.length > 0
? Math.max(lastUpdatedTime, allSidebarItems[0].lastUpdatedTime)
: lastUpdatedTime;
const sidebarItems = getSidebarItems(allSidebarItems); const allInitialSidebarItems = getAllInitialSidebarItems(sidebars);
const sidebarItems = getSidebarItems(allInitialSidebarItems);
return { return {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
lastUpdatedTime, lastUpdatedTime: lastUpdatedAtLeastTime,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars:
lastUpdatedAtLeastTimeIncludingSidebars,
sidebars: sidebarItems, sidebars: sidebarItems,
}; };
}, },
[messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes], [messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes],
); );
} }
function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> { function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> {
▲ Show 20 Lines • Show All 488 Lines • Show Last 20 Lines
View Options

native/markdown/markdown-link.react.js

Show All 19 Linesimport {
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesfunction useCreateChatThreadItem(): ThreadInfo => ChatThreadItem {
const getLastUpdatedTimes = useGetLastUpdatedTimes(); const getLastUpdatedTimes = useGetLastUpdatedTimes();
return React.useCallback( return React.useCallback(
threadInfo => { threadInfo => {
const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID( const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID(
threadInfo.id, threadInfo.id,
messageStore, messageStore,
); );
const { lastUpdatedAtLeastTime: lastUpdatedTime } = getLastUpdatedTimes( const { lastUpdatedAtLeastTime } = getLastUpdatedTimes(
threadInfo, threadInfo,
messageStore, messageStore,
messageInfos, messageInfos,
); );
const sidebars = sidebarInfos[threadInfo.id] ?? []; const sidebars = sidebarInfos[threadInfo.id] ?? [];
const allSidebarItems = sidebars.map(sidebarInfo => ({ const lastUpdatedAtLeastTimeIncludingSidebars =
type: 'sidebar', sidebars.length > 0
...sidebarInfo, ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
})); : lastUpdatedAtLeastTime;
const lastUpdatedTimeIncludingSidebars =
allSidebarItems.length > 0
? Math.max(lastUpdatedTime, allSidebarItems[0].lastUpdatedTime)
: lastUpdatedTime;
const sidebarItems = getSidebarItems(allSidebarItems); const allInitialSidebarItems = getAllInitialSidebarItems(sidebars);
const sidebarItems = getSidebarItems(allInitialSidebarItems);
return { return {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
lastUpdatedTime, lastUpdatedTime: lastUpdatedAtLeastTime,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars:
lastUpdatedAtLeastTimeIncludingSidebars,
sidebars: sidebarItems, sidebars: sidebarItems,
}; };
}, },
[messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes], [messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes],
); );
} }
function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> { function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> {
▲ Show 20 Lines • Show All 488 Lines • Show Last 20 Lines